From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id DA6593858D32 for ; Tue, 26 Jul 2022 12:28:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA6593858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9AxeeAB3t9iDLk5AA--.17980S2; Tue, 26 Jul 2022 20:28:49 +0800 (CST) Subject: Re: [PATCH][wwwdocs] gcc-13: Add loongarch '-mexplicit-relocs' support To: Gerald Pfeifer Cc: gcc-patches@gcc.gnu.org, xuchenghua@loongson.cn References: <20220726072119.2910839-1-chenglulu@loongson.cn> From: Lulu Cheng Message-ID: <105cd635-9f16-63f4-8fa5-2d2a08c1df04@loongson.cn> Date: Tue, 26 Jul 2022 20:28:49 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CM-TRANSID: AQAAf9AxeeAB3t9iDLk5AA--.17980S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJryDCryrZrW8CFW7AryxZrb_yoW8XryDpr W0grWYvF1xXr1Ikw10yas7Jw1rur4rXFnxCryFgw1qyrn8Grn2vFn2gr1ru3s8CF1Ygw42 v3W8Gry8Aa1DArDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvI14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487McIj6xIIjxv20xvE14v26r1j6r18McIj6I8E 87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lF7I21c0EjI I2zVCS5cI20VAGYxC7Mx8GjcxK6IxK0xIIj40E5I8CrwCYjI0SjxkI62AI1cAE67vIY487 MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c 02F40E14v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_ JF1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7 CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE 14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf 9x0JUp5l8UUUUU= X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, BODY_8BITS, HTML_MESSAGE, KAM_DMARC_STATUS, MIME_CHARSET_FARAWAY, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2022 12:28:54 -0000 ÔÚ 2022/7/26 ÏÂÎç7:32, Gerald Pfeifer дµÀ: > On Tue, 26 Jul 2022, Lulu Cheng wrote: >> +

LoongArch

>> +
    >> +
  • The option -mexplicit-relocs has been added, this indicates >> + whether the la.* macro instructions will be generated when >> + loading symbolic addresses. > How about making this "...has been added. It indicates..." or, if you > prefer one sentence "...has been added to indicate whether"? > >> + This feature requires binutils version 2.40 or later. If you want to use the >> + older version of bintuils, add compiler parameters >> + -mno-explicit-relocs at compile time. > "...older versions..." (or "...an older version...") > > And I believe we can simplify and just say "...add -mno-explicit..." > >> +
  • The method for calling global functions changed from >> + la.global + jirl to bl when complied add >> + -fplt. > Do you mean "compiled" instead of "complied"? > > And maybe "compiled with"? > >> +
  • Enable option -fsection-anchors when -O1 and >> + more advanced optimization. > How about "-fsection-anchors is now enabled with > -O1 and above"? > > > If my suggestions make sense to you, please go ahead and commit with those > or variations thereof you may prefer. > > If you have any questions, please let me know and we'll sort things out > quickly. > > Thank you, > Gerald Thanks a lot, I will fix it soon. Lulu Cheng