public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jim Wilson <wilson@specifixinc.com>
To: Geoff Keating <geoffk@geoffk.org>
Cc: gcc-patches@gcc.gnu.org, Daniel Jacobowitz <drow@mvista.com>
Subject: Re: avoid unnecessary register saves for setjmp
Date: Sat, 22 Nov 2003 00:20:00 -0000	[thread overview]
Message-ID: <1069458021.1020.89.camel@leaf.tuliptree.org> (raw)
In-Reply-To: <jmwu9t5vn5.fsf@desire.geoffk.org>

On Fri, 2003-11-21 at 12:11, Geoff Keating wrote:
> I've looked at this some time in the past (I don't remember the exact
> circumstances).  I came to the same conclusion as you, except in the
> case when NON_SAVING_SETJMP is defined, when we do need to save any
> call-saved registers.

There is code in final_start_function to do this.  However, this can
only work if you aren't using register elimination, and if you are
emitting assembly language prologues instead of using RTL patterns in
the md file.  So this could only work for old ports.

Checking, I see that the only port that uses NON_SAVING_SETJMP is the
x86 svr3 port, and I am fairly certain that is a dead port.  Yes, I see
it on Nathanael Nerode's obsolete list for 3.4.  Actually, it looks like
this is the only target that ever used this macro.

If we really need this to work, then we can move the code from
final_start_function to reload.  This will give code very similar to
what I just deleted, except that it tests NON_SAVING_SETJMP.

Or we can just obsolete all of the NON_SAVING_SETJMP support, as I
believe we don't need it anymore.  It seems very unlikely that we need
gcc to support systems with a broken setjmp() library function.  The
original definition of the macro might even have been based on a
misunderstanding of what setjmp does.

I think dropping the NON_SAVING_SETJMP support is the more sensible
solution.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com

  reply	other threads:[~2003-11-21 23:40 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-21  5:54 Jim Wilson
2003-11-21 18:39 ` Daniel Jacobowitz
2003-11-22  0:22   ` Jim Wilson
2003-11-22  3:57     ` Daniel Jacobowitz
2003-11-22  9:06       ` Jim Wilson
2003-11-22 14:37         ` Richard Earnshaw
2003-11-22 16:33           ` Daniel Jacobowitz
2003-11-27  9:11             ` Zack Weinberg
2003-11-27 17:11               ` Andrew Pinski
2003-11-27 18:23                 ` Zack Weinberg
2003-11-28  5:15                   ` Geert Bosch
2003-11-28 11:14                   ` Richard Earnshaw
2003-11-28 14:02             ` Richard Earnshaw
2003-11-21 20:14 ` Geoff Keating
2003-11-22  0:20   ` Jim Wilson [this message]
2003-11-30  9:23   ` Jim Wilson
2003-11-22  4:13 Richard Kenner
2003-12-01  3:29 ` Jim Wilson
2003-11-27  9:19 Chris Lattner
2003-11-27  9:21 ` Andrew Haley
2003-11-27  9:22   ` Chris Lattner
2003-11-27  9:39     ` Andrew Haley
2003-11-27  9:43       ` Chris Lattner
2003-11-27 10:14       ` Zack Weinberg
2003-11-27 10:15         ` Chris Lattner
2003-11-27 11:01           ` Zack Weinberg
2003-11-27 20:28             ` Chris Lattner
2003-11-27 20:51               ` Gabriel Dos Reis
2003-11-27 15:41           ` Jan Vroonhof
2003-11-27 16:23           ` Jan Vroonhof
2003-11-27 10:31         ` Andrew Haley
2003-11-27 10:53           ` Zack Weinberg
     [not found] <5cad8ef043da68f2a3332f00bd6a186a3fc6195b@mail.esmertec.com>
2003-11-27 20:44 ` Chris Lattner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1069458021.1020.89.camel@leaf.tuliptree.org \
    --to=wilson@specifixinc.com \
    --cc=drow@mvista.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=geoffk@geoffk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).