public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <rguenther@suse.de>
To: "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	 Richard Sandiford <richard.sandiford@arm.com>
Subject: Re: [PATCH][gcc][middle-end] PR104498: Fix comparing symbol reference
Date: Thu, 17 Feb 2022 10:54:57 +0100 (CET)	[thread overview]
Message-ID: <106q69n4-nsr3-rr81-rs55-29o26p729126@fhfr.qr> (raw)
In-Reply-To: <9eb88215-8d5c-c39d-7aae-d2f8aa2d8795@arm.com>

On Wed, 16 Feb 2022, Andre Vieira (lists) wrote:

> Hi,
> 
> As reported on PR104498, the issue here is that when compare_base_symbol_refs
> swaps x and y but doesn't take that into account when computing the distance.
> This patch makes sure that if x and y are swapped, we correct the distance
> computation by multiplying it by -1 to end up with the correct expected result
> of the original Y_BASE - X_BASE.
> 
> Bootstrapped and regression tested on aarch64-none-linux.
> 
> OK for trunk?

OK.

Thanks,
Richard.

> gcc/ChangeLog:
> 
>         PR middle-end/104498
>         * alias.cc (compare_base_symbol_refs): Correct distance 
> computation when
>         swapping x and y.
> 

      reply	other threads:[~2022-02-17  9:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16 11:12 Andre Vieira (lists)
2022-02-17  9:54 ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=106q69n4-nsr3-rr81-rs55-29o26p729126@fhfr.qr \
    --to=rguenther@suse.de \
    --cc=andre.simoesdiasvieira@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).