From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-201303-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 392 invoked by alias); 11 Aug 2007 15:00:32 -0000
Received: (qmail 32677 invoked by uid 22791); 11 Aug 2007 15:00:32 -0000
X-Spam-Check-By: sourceware.org
Received: from VLSI1.ULTRA.NYU.EDU (HELO vlsi1.ultra.nyu.edu) (128.122.140.213)     by sourceware.org (qpsmtpd/0.31) with SMTP; Sat, 11 Aug 2007 15:00:26 +0000
Received: by vlsi1.ultra.nyu.edu (4.1/1.34) 	id AA14484; Sat, 11 Aug 07 11:03:50 EDT
From: kenner@vlsi1.ultra.nyu.edu (Richard Kenner)
Message-Id: <10708111503.AA14484@vlsi1.ultra.nyu.edu>
Date: Sat, 11 Aug 2007 15:00:00 -0000
To: ghazi@caip.rutgers.edu
Subject: Re: [Ada PATCH INSTALLED]: constifications
Cc: gcc-patches@gcc.gnu.org
In-Reply-To: <Pine.GSO.4.58.0708110945380.20555@caipclassic.rutgers.edu>
References: <Pine.GSO.4.58.0708110945380.20555@caipclassic.rutgers.edu>
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-08/txt/msg00737.txt.bz2

Thanks for doing this.  Two minor issues:

> +  const_tree const field1 = * (const_tree const*) rt1;
> +  const_tree const field2 = * (const_tree const*) rt2;

Please fix the missing blank before the second "*".

> +  const int ret = tree_int_cst_compare (bit_position (field1), bit_position (field2));

Isn't this line too long?

The same problems are in utils2.c.