From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 511F23851C04 for ; Wed, 6 Jan 2021 11:49:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 511F23851C04 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=botcazou@adacore.com Received: by mail-ej1-x62d.google.com with SMTP id qw4so4552648ejb.12 for ; Wed, 06 Jan 2021 03:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OR5KFtlPzqBgKaaUHpg/TicV/s/ClXkzg++Oxgb2AhA=; b=uzXeSkSvFnwHply4SAOHezQMLhTbntbTiGOzgfpiEWfapGzYxduA0s58qc5P69X7RA HFtOU7/AOKoff1tUoZ2LebEIpg0KQdFFYztSvEcI30/GItpVFUNYvT+zZGV9IM7m2Ob6 KSNlIa1Jv4+iN1BemC9vaskpPqbw1Upqqporn5BbdsS2mmCE3BxwWC1QQXoFZyjar+Mh ueGuiqtJ4+Tne3Sr6WRxvKqDvUBzhvW7DsmH1Z5BoKEBW3lCQ3WWFynKUTMEzbsJSieR 0i39QddCsjzwETbeLfih0c2j0Lapl/2kAKtYMC6JT0p9Je0CGLEsK6woL0SlXbQRkrqK AQSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OR5KFtlPzqBgKaaUHpg/TicV/s/ClXkzg++Oxgb2AhA=; b=SeC6lydkr5B6LJOX+A9xYPaXRJ047/1I6M/1L8ZB19N3orxdK228VEuIo8ghyyzpvN 34GYZpyNYbMtUooGI9LMNgldCy0606jRha0cIEth+qGWQq9KPb44I9elojZ18btfOzpJ TM8Md0wldgLeg6xgJPHcpkZVKrPQT2LBcZei9n4q3wTo084r3EtUP8nxQFLF7o5WU+2j skN8fSz/WOehaqOPlocK7kxFm6LU6AYEmw4Z1EYA9tU0H4sg748uxGGGJVS8Qfb6oAkl yBBgwy+TkTvDmNXTFL57ZWyVJZydEJWslQ7LnEg6on+4Ojf14UaSPCty60UQeMAHgMrh P4XA== X-Gm-Message-State: AOAM531R0FMSw6I4VAbxym+40T7bY3DG5HDkGNd73ZrjP77r1Gr409CO htc5zlMEfc4BqgiZ0hARLDjGPQ== X-Google-Smtp-Source: ABdhPJxjWQU/BbchbMHbyL6WaxyHDZo2f1BotHpYwNAf9GadZXDikysdWz5/LNh831GUBime6Uwo5w== X-Received: by 2002:a17:906:4d8d:: with SMTP id s13mr2599649eju.305.1609933762451; Wed, 06 Jan 2021 03:49:22 -0800 (PST) Received: from fomalhaut.localnet ([2a01:e0a:41b:84f0:cf71:f5e0:b050:bede]) by smtp.gmail.com with ESMTPSA id i15sm1150741ejj.28.2021.01.06.03.49.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Jan 2021 03:49:21 -0800 (PST) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Bernd Edlinger Cc: gcc-patches@gcc.gnu.org, Richard Biener , Jakub Jelinek , Alexandre Oliva Subject: Re: [PATCH] Add line debug info for virtual thunks (PR ipa/97937) Date: Wed, 06 Jan 2021 12:49:20 +0100 Message-ID: <10885401.ZfXygJoTAh@fomalhaut> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2021 11:49:24 -0000 > currently there is a problem when debugging a virtual thunk. That is > a decl with DECL_IGNORED_P. Currently the line information displayed > in gdb is completely bogus, thus the last line of whatever function > is immediately before the PC of the thunk. DECL_IGNORED_P means completely ignored for debug info purposes though and I think that the Ada compiler expects this semantic. > This patch improves the debug experience at least a bit by emitting > at the line number information where the thunk has been defined. > I do not dare to touch anything but dwarf2 debug info, therefore > the patch is a bit awkward. Please run the GDB testsuite with Ada support on the patch. -- Eric Botcazou