From: Diego Novillo <dnovillo@redhat.com>
To: Richard Kenner <kenner@vlsi1.ultra.nyu.edu>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: Fix processing of ADDR_EXPR in get_expr_operands
Date: Fri, 30 Jul 2004 15:12:00 -0000 [thread overview]
Message-ID: <1091152964.5942.187.camel@localhost.localdomain> (raw)
In-Reply-To: <10407300156.AA13423@vlsi1.ultra.nyu.edu>
On Thu, 2004-07-29 at 21:56, Richard Kenner wrote:
> I still haven't seen an answer to why we're not marking addresses of
> volatile as constant, which I think is the real bug here.
>
Invariant addresses are supposed to be marked with TREE_INVARIANT, not
TREE_CONSTANT. That's what I've been told by the FE folks and that's
why the tree optimizers almost always rely on is_gimple_min_invariant().
/* Value of expression is function invariant. A strict subset of
TREE_CONSTANT, such an expression is constant over any one function
invocation, though not across different invocations. May appear in
any expression node. */
#define TREE_INVARIANT(NODE) ((NODE)->common.invariant_flag)
> It's possible the bug my original change fixed is no longer relevant, but
> if this breaks something, I'll let you know.
>
Make your FE set TREE_INVARIANT on "constant" ADDR_EXPRs and it will all
work fine in get_expr_operands.
Diego.
next prev parent reply other threads:[~2004-07-30 2:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-30 14:19 Richard Kenner
2004-07-30 15:12 ` Diego Novillo [this message]
2004-07-30 18:26 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2004-07-30 23:39 Richard Kenner
2004-07-30 20:48 Richard Kenner
2004-07-30 21:17 ` Diego Novillo
2004-07-30 19:02 Richard Kenner
2004-07-30 15:51 Richard Kenner
2004-07-30 19:05 ` Diego Novillo
2004-07-30 15:43 Richard Kenner
2004-07-30 15:44 ` Diego Novillo
2004-07-30 18:28 ` Richard Henderson
2004-07-29 23:40 Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1091152964.5942.187.camel@localhost.localdomain \
--to=dnovillo@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kenner@vlsi1.ultra.nyu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).