From: Jeffrey A Law <law@redhat.com>
To: Andrew Pinski <pinskia@physics.uc.edu>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PRs middle-end/15014 and middle-end/16973, removing labels with their address taken
Date: Wed, 06 Oct 2004 17:03:00 -0000 [thread overview]
Message-ID: <1097082097.22266.1721.camel@localhost.localdomain> (raw)
In-Reply-To: <3F36926E-173D-11D9-B1A5-000A95D692F4@physics.uc.edu>
On Tue, 2004-10-05 at 20:13, Andrew Pinski wrote:
> On Oct 5, 2004, at 6:35 PM, Jeffrey A Law wrote:
> > If we're going to allow this, then I would strongly recommend
> > against this approach to the problem. Instead just move
> > these labels to the start of their nearest following block that
> > is reachable.
> Well then you have to fix cfgcleanup which is done using non-tree
> or non-RTL code. This is much harder than it should be for the
> problem at hand which is why I picked the method I did.
Harder or not, it's a much better solution.
>
> > Inserting arbitrary edges into the CFG is generally bad.
>
> Usually it is but this case does not show up too much so really
> it should not matter that much as I said before.
We've already been down this road before. Adding bogus edges to the
CFG is bad bad bad.
Jeff
next prev parent reply other threads:[~2004-10-06 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 15:06 Andrew Pinski
2004-10-05 22:40 ` Jeffrey A Law
2004-10-05 23:12 ` Joseph S. Myers
2004-10-06 2:35 ` Andrew Pinski
2004-10-06 17:03 ` Jeffrey A Law [this message]
2004-10-10 18:01 ` Andrew Pinski
2004-10-18 19:27 ` Jeffrey A Law
2004-10-18 20:19 ` Andrew Pinski
2004-10-18 21:37 Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097082097.22266.1721.camel@localhost.localdomain \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pinskia@physics.uc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).