From: Richard Earnshaw <rearnsha@arm.com>
To: Paul Brook <paul@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [arm] Fix thumb -fPIC
Date: Wed, 13 Oct 2004 09:08:00 -0000 [thread overview]
Message-ID: <1097657960.23033.57.camel@pc960.cambridge.arm.com> (raw)
In-Reply-To: <200410121951.54908.paul@codesourcery.com>
On Tue, 2004-10-12 at 19:51, Paul Brook wrote:
> > > (thumb_find_work_register): Search full register range.
> >
> > I'm not 100% sure about the second issue. LAST_LO_REGNUM is sometimes
> > used as a frame pointer register when we can't manage without one, have
> > you checked that it's safe to use it as a scratch in these conditions
> > (it may be, but I'm not sure).
>
> I checked the function prologue usage, but missed the the use from
> builtin_setjmp_reciever. Patch below fixes this case, which seemed to be
> working by chance.
>
> Tested with cross to arm-none-elf.
> Ok?
>
> Paul
>
> 2004-10-12 Paul Brook <paul@codesourcery.com>
>
> * config/arm/arm-protos.h (arm_load_pic_register): Update prototype.
> * config/arm/arm.c (thumb_find_work_register): Update comments.
> (arm_load_pic_register): Add argument for scratch register.
> (arm_expand_prologue, thumb_expand_prologue): Pass extra argument.
> * config/arm/arm.md (builtin_setjmp_receiver): Ditto.
OK.
R.
prev parent reply other threads:[~2004-10-13 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-01 16:25 Paul Brook
2004-10-12 11:59 ` Richard Earnshaw
2004-10-12 19:14 ` Paul Brook
2004-10-13 9:08 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097657960.23033.57.camel@pc960.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).