From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-130770-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 5847 invoked by alias); 13 Oct 2004 08:59:26 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 5839 invoked from network); 13 Oct 2004 08:59:24 -0000
Received: from unknown (HELO cam-admin0.cambridge.arm.com) (193.131.176.58)
  by sourceware.org with SMTP; 13 Oct 2004 08:59:24 -0000
Received: from pc960.cambridge.arm.com (pc960.cambridge.arm.com [10.1.205.4])
	by cam-admin0.cambridge.arm.com (8.12.10/8.12.10) with ESMTP id i9D8wqxm028406;
	Wed, 13 Oct 2004 09:58:52 +0100 (BST)
Received: from pc960.cambridge.arm.com (localhost.localdomain [127.0.0.1])
	by pc960.cambridge.arm.com (8.12.8/8.12.8) with ESMTP id i9D8xMgK025963;
	Wed, 13 Oct 2004 09:59:22 +0100
Received: (from rearnsha@localhost)
	by pc960.cambridge.arm.com (8.12.8/8.12.8/Submit) id i9D8xLj1025961;
	Wed, 13 Oct 2004 09:59:21 +0100
X-Authentication-Warning: pc960.cambridge.arm.com: rearnsha set sender to rearnsha@arm.com using -f
Subject: Re: [arm] Fix thumb -fPIC
From: Richard Earnshaw <rearnsha@arm.com>
To: Paul Brook <paul@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
In-Reply-To: <200410121951.54908.paul@codesourcery.com>
References: <200410011645.34143.paul@codesourcery.com>
	 <1097579089.23033.7.camel@pc960.cambridge.arm.com>
	 <200410121951.54908.paul@codesourcery.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1097657960.23033.57.camel@pc960.cambridge.arm.com>
Mime-Version: 1.0
Date: Wed, 13 Oct 2004 09:08:00 -0000
X-SW-Source: 2004-10/txt/msg01084.txt.bz2

On Tue, 2004-10-12 at 19:51, Paul Brook wrote:
> > >  (thumb_find_work_register): Search full register range.
> >
> > I'm not 100% sure about the second issue.  LAST_LO_REGNUM is sometimes
> > used as a frame pointer register when we can't manage without one, have
> > you checked that it's safe to use it as a scratch in these conditions
> > (it may be, but I'm not sure).
> 
> I checked the function prologue usage, but missed the the use from 
> builtin_setjmp_reciever. Patch below fixes this case, which seemed to be 
> working by chance.
> 
> Tested with cross to arm-none-elf.
> Ok?
> 
> Paul
> 
> 2004-10-12  Paul Brook  <paul@codesourcery.com>
> 
>  * config/arm/arm-protos.h (arm_load_pic_register): Update prototype.
>  * config/arm/arm.c (thumb_find_work_register): Update comments.
>  (arm_load_pic_register): Add argument for scratch register.
>  (arm_expand_prologue, thumb_expand_prologue): Pass extra argument.
>  * config/arm/arm.md (builtin_setjmp_receiver): Ditto.

OK.

R.