From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14108 invoked by alias); 18 Oct 2004 20:23:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14090 invoked from network); 18 Oct 2004 20:22:59 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 18 Oct 2004 20:22:59 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i9IKMwAo002975; Mon, 18 Oct 2004 16:22:58 -0400 Received: from [172.16.83.144] (vpn83-144.boston.redhat.com [172.16.83.144]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i9IKMqr29743; Mon, 18 Oct 2004 16:22:52 -0400 Subject: Re: [patch] expr.c: Don't request a value to expand_assignment. From: Jeffrey A Law Reply-To: law@redhat.com To: Kazu Hirata Cc: gcc-patches@gcc.gnu.org In-Reply-To: <20041016.083224.126575780.kazu@cs.umass.edu> References: <20041016.083224.126575780.kazu@cs.umass.edu> Content-Type: text/plain Organization: Red Hat, Inc Message-Id: <1098130971.2915.69.camel@localhost.localdomain> Mime-Version: 1.0 Date: Mon, 18 Oct 2004 20:29:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg01542.txt.bz2 On Sat, 2004-10-16 at 06:32, Kazu Hirata wrote: > Hi, > > Attached is a patch to not request a value to expand_assignment when > expanding a MODIFY_EXPR. > > As far as I know, the tree-ssa infrastructure does not generate tree > that requests a value of an assignment (e.g. a = b = c;) regardless of > whether optimizing or not. > > This is the only place that requests a value to expand_assignment. > Once this patch is applied, we can clean up expand_assignment so that > it won't have to bother returning a value. > > Tested on i686-pc-linux-gnu. OK to apply? > > Kazu Hirata > > 2004-10-15 Kazu Hirata > > * expr.c (expand_expr_real_1) [MODIFY_EXPR]: Don't request a > value to expand_assignment. This is fine. Please install. jeff