From: Diego Novillo <dnovillo@redhat.com>
To: Daniel Berlin <dberlin@dberlin.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Andrew Macleod <amacleod@redhat.com>
Subject: Re: [PATCH]: Implement must-def kill operand
Date: Wed, 20 Oct 2004 21:04:00 -0000 [thread overview]
Message-ID: <1098306201.22552.63.camel@localhost.localdomain> (raw)
In-Reply-To: <531813B6-22DA-11D9-B310-000D93B1B044@dberlin.org>
On Wed, 2004-10-20 at 16:55, Daniel Berlin wrote:
> That will, in turn, mark the *feeders* of the phi as necessary, because
> they will be added to the worklist, and propagate_necessity doesn't
> know that it doesn't need to mark the feeders unless they are phi
> nodes, thus you will miss dead code being eliminated.
>
Ah, good point. Sigh. I think I'm about to ask you to just let the
regular renamer run and insert needed PHIs, but I agree that PHI node
churn should be avoided.
How much additional code are we talking about? A good chunk of the
algorithm you described already exists in DCE. Can it be factored?
Diego.
next prev parent reply other threads:[~2004-10-20 21:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-18 2:29 Daniel Berlin
2004-10-20 17:41 ` Diego Novillo
2004-10-20 17:56 ` Daniel Berlin
2004-10-20 18:08 ` Diego Novillo
2004-10-20 18:28 ` Daniel Berlin
2004-10-20 20:36 ` Diego Novillo
2004-10-20 20:49 ` Daniel Berlin
2004-10-20 20:57 ` Diego Novillo
2004-10-20 21:01 ` Daniel Berlin
[not found] ` <531813B6-22DA-11D9-B310-000D93B1B044@dberlin.org>
2004-10-20 21:04 ` Diego Novillo [this message]
2004-10-20 21:27 ` Daniel Berlin
2004-10-20 22:23 ` Andrew Pinski
2004-10-23 5:02 ` Mark Mitchell
2004-10-23 12:56 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098306201.22552.63.camel@localhost.localdomain \
--to=dnovillo@redhat.com \
--cc=amacleod@redhat.com \
--cc=dberlin@dberlin.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).