From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 316513857C7D for ; Tue, 12 Dec 2023 11:08:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 316513857C7D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 316513857C7D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702379333; cv=none; b=ClgJ7XV1Ca5VC/1S9yPwIhyL7NsICUaoVfOzdJYPe4yplTtyKw9v6acEBS5dyh3nm60F3smd13KhwzK/yP4H30xkaJsuyVeh48cNOZi0/0eqt0SE+pOoL1D9F7QLtoNGQIS4RiHpFDxXsSxw/BEqo5g6rkS6/Zom23PkOKFsI68= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702379333; c=relaxed/simple; bh=kFkqXFE73eAgHu7SlR34UnCdh1I+YJWJPnSkAOBDfOU=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=ZId1ct/8udzlsnoCwHRnXx43D+f4AWecbXQ5FDhyhYAG6/Eq3TQAEEby0DJ/cEi/9EaTTf4Gz8CDk2fzKdFiaUYi3QiC6XfYkcHbysRD7i25+GBOReaLyNSyrqpa9V0bWODmeiguRT7WGeKdYxpy9tMPe6Gt1tEcPJEqiZTLyNI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.105]) by gateway (Coremail) with SMTP id _____8BxK+k2P3hlKlIAAA--.2009S3; Tue, 12 Dec 2023 19:08:38 +0800 (CST) Received: from [10.20.4.105] (unknown [10.20.4.105]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxnuE1P3hlUIIAAA--.3771S3; Tue, 12 Dec 2023 19:08:37 +0800 (CST) Subject: Re: [PATCH] LoongArch: Define LOGICAL_OP_NON_SHORT_CIRCUIT. To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, chenglulu@loongson.cn, xuchenghua@loongson.cn References: <20231212095006.12830-1-xujiahao@loongson.cn> <975c0060f6dfc4b33c03f8a57d7d190050dc01a1.camel@xry111.site> From: Jiahao Xu Message-ID: <109c3145-ac7a-f0e4-9a3d-4510ca0da403@loongson.cn> Date: Tue, 12 Dec 2023 19:08:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <975c0060f6dfc4b33c03f8a57d7d190050dc01a1.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8CxnuE1P3hlUIIAAA--.3771S3 X-CM-SenderInfo: 50xmxthkdrqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj9xXoWrKFyDuryUJrWrZw1ruF47Jrc_yoWDKFb_Kw 1xZrs5CF4rCa4fJ3s0q345JFy3JF4qyryIyFnIyFsrWa45XFs5Aanrta4fuFyUZa95XFW3 Wr9aqFZFy39IgosvyTuYvTs0mTUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbI8YFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUJVWUCwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8C rVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtw CIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x02 67AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr 0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUzsqW UUUUU X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2023/12/12 下午6:05, Xi Ruoyao 写道: > On Tue, 2023-12-12 at 17:50 +0800, Jiahao Xu wrote: >> diff --git a/gcc/testsuite/gcc.target/loongarch/short-circuit.c b/gcc/testsuite/gcc.target/loongarch/short-circuit.c >> new file mode 100644 >> index 00000000000..2cef0193466 >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/loongarch/short-circuit.c >> @@ -0,0 +1,19 @@ >> +/* { dg-do compile } */ >> +/* { dg-options "-O2 -fdump-tree-gimple" } */ >> + >> +int >> +short_circuit (float *a) >> +{ >> +  float t1x = a[0]; >> +  float t2x = a[1]; >> +  float t1y = a[2]; >> +  float t2y = a[3]; >> +  float t1z = a[4]; >> +  float t2z = a[5]; >> + >> +  if (t1x > t2y  || t2x < t1y  || t1x > t2z || t2x < t1z || t1y > t2z || t2y < t1z) >> +    return 0; >> + >> +  return 1; >> +} >> +/* { dg-final { scan-tree-dump-times "if" 6 "gimple" } } */ > This test already passes without defining LOGICAL_OP_NON_SHORT_CIRCUIT. > Or am I missing something here? This test also needs to add the compilation option -ffast-math. I missed it. Thanks for the reminder. >