From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 3DB673858C60 for ; Fri, 27 Aug 2021 21:28:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3DB673858C60 Received: by mail-pg1-x533.google.com with SMTP id w8so6979658pgf.5 for ; Fri, 27 Aug 2021 14:28:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+vsGN2Ci0t+Jl7EKkWdjQVBIOQrZrQeikqLB3x/cBbs=; b=jbbh3ZyA17Nr8DquBhUi68ELqkXbXK+oQUKgxqOc67onJAQd9DwuE1fkbmsQF7BvDH bs+WPvVS6r6+gt4/cUpIJks/D0zazYTH2Mo6txdhT509weNf2I98exQopbG8omokXbty cXqBRpovoVZBx9wSlH7R9HBrJyXhsSXzq1b2nEWsNUmb5nB1ulc+w1Mg1EfWwoMn7iVc wfBTLQq2zEgPfgHx1EuQ7ephfiZhv+SrWyi1TdULbiEwoGBtO56oQLePqctJ6rmHJ/d4 uj2RJ6OSRQhHl/YbL2Of3rhkJ+FyQ7wKAX4hGaqFOuE9ruAAq4Xp0ghR5IrXoEnGQZQN 2LNA== X-Gm-Message-State: AOAM530ebnV/Wr+UcfL7F/Ezvilv8kYSvlP2u6MdrpGn7bi0ZG49WQoI zFXoiIeJG6/hn31RVp9FaKEhVXljHts6ig== X-Google-Smtp-Source: ABdhPJySDY9PzSHfijdAMCbTNNOo66IbaPQ0IQcnhBxh7y1s7LXBEfgY4IP744huJ3L58na2SZjc6w== X-Received: by 2002:a63:ed17:: with SMTP id d23mr9520517pgi.223.1630099708916; Fri, 27 Aug 2021 14:28:28 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id y7sm7276227pff.206.2021.08.27.14.28.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Aug 2021 14:28:28 -0700 (PDT) Subject: Re: [PATCH] libffi: Fix MIPS r6 support To: YunQiang Su , gcc-patches@gcc.gnu.org References: <20210827045809.59150-1-yunqiang.su@cipunited.com> From: Jeff Law Message-ID: <10c8246a-b621-dcdb-6472-854c7bab38c1@gmail.com> Date: Fri, 27 Aug 2021 15:28:27 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210827045809.59150-1-yunqiang.su@cipunited.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2021 21:28:32 -0000 On 8/26/2021 10:58 PM, YunQiang Su wrote: > for some instructions, MIPS r6 uses different encoding other than > the previous releases. > > 1. mips/n32.S disable .set mips4: since it casuses old insn encoding > is used. > https://github.com/libffi/libffi/pull/396 > 2. mips/ffi.c: the encoding for JR is hardcoded: we need to use > different value for r6 and pre-r6. > https://github.com/libffi/libffi/pull/401 > > libffi/ > PR libffi/83636 > * src/mips/n32.S: disable .set mips4 > * src/mips/ffi.c: use different JR encoding for r6. These should go to the upstream libffi project.  Once accepted there you can add them to GCC. Jeff