public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] IBM Z: Fix constraints in vpdi patterns
@ 2021-01-08 16:35 Ilya Leoshkevich
  2021-01-08 16:51 ` Andreas Krebbel
  0 siblings, 1 reply; 2+ messages in thread
From: Ilya Leoshkevich @ 2021-01-08 16:35 UTC (permalink / raw)
  To: krebbel; +Cc: gcc-patches, Ilya Leoshkevich

Bootstrapped and regtested on s390x-redhat-linux.  Ok for master?



The destination register is only partially overwritten, so + should be
used instead of =.

gcc/ChangeLog:

2021-01-08  Ilya Leoshkevich  <iii@linux.ibm.com>

	* config/s390/vector.md (*tf_to_fprx2_0): Rename from
	*mov_tf_to_fprx2_0 for consistency, fix constraint.
	(*tf_to_fprx2_1): Rename from *mov_tf_to_fprx2_1 for
	consistency, fix constraint.
---
 gcc/config/s390/vector.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md
index 5b8d75f18f0..0e3c31f5d4f 100644
--- a/gcc/config/s390/vector.md
+++ b/gcc/config/s390/vector.md
@@ -737,16 +737,16 @@ (define_insn "*vec_perm<mode>"
   "vperm\t%v0,%v1,%v2,%v3"
   [(set_attr "op_type" "VRR")])
 
-(define_insn "*mov_tf_to_fprx2_0"
-  [(set (subreg:DF (match_operand:FPRX2 0 "nonimmediate_operand" "=f") 0)
+(define_insn "*tf_to_fprx2_0"
+  [(set (subreg:DF (match_operand:FPRX2 0 "nonimmediate_operand" "+f") 0)
 	(subreg:DF (match_operand:TF    1 "general_operand"       "v") 0))]
   "TARGET_VXE"
   ; M4 == 1 corresponds to %v0[0] = %v1[0]; %v0[1] = %v0[1];
   "vpdi\t%v0,%v1,%v0,1"
   [(set_attr "op_type" "VRR")])
 
-(define_insn "*mov_tf_to_fprx2_1"
-  [(set (subreg:DF (match_operand:FPRX2 0 "nonimmediate_operand" "=f") 8)
+(define_insn "*tf_to_fprx2_1"
+  [(set (subreg:DF (match_operand:FPRX2 0 "nonimmediate_operand" "+f") 8)
 	(subreg:DF (match_operand:TF    1 "general_operand"       "v") 8))]
   "TARGET_VXE"
   ; M4 == 5 corresponds to %V0[0] = %v1[1]; %V0[1] = %V0[1];
-- 
2.26.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] IBM Z: Fix constraints in vpdi patterns
  2021-01-08 16:35 [PATCH] IBM Z: Fix constraints in vpdi patterns Ilya Leoshkevich
@ 2021-01-08 16:51 ` Andreas Krebbel
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Krebbel @ 2021-01-08 16:51 UTC (permalink / raw)
  To: Ilya Leoshkevich; +Cc: gcc-patches

On 1/8/21 5:35 PM, Ilya Leoshkevich wrote:
> Bootstrapped and regtested on s390x-redhat-linux.  Ok for master?
> 
> 
> 
> The destination register is only partially overwritten, so + should be
> used instead of =.
> 
> gcc/ChangeLog:
> 
> 2021-01-08  Ilya Leoshkevich  <iii@linux.ibm.com>
> 
> 	* config/s390/vector.md (*tf_to_fprx2_0): Rename from
> 	*mov_tf_to_fprx2_0 for consistency, fix constraint.
> 	(*tf_to_fprx2_1): Rename from *mov_tf_to_fprx2_1 for
> 	consistency, fix constraint.

Ok, thanks!

Andreas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-08 16:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 16:35 [PATCH] IBM Z: Fix constraints in vpdi patterns Ilya Leoshkevich
2021-01-08 16:51 ` Andreas Krebbel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).