* Re: [PATCH] PR105647 Update pr105169* so it does not fail on powerpc64le
[not found] <20220518193652.11699-1-gbelinassi@suse.de>
@ 2022-05-19 6:34 ` Richard Biener
2022-05-19 13:01 ` Giuliano Belinassi
0 siblings, 1 reply; 2+ messages in thread
From: Richard Biener @ 2022-05-19 6:34 UTC (permalink / raw)
To: Giuliano Belinassi; +Cc: gcc-patches, matz, seurer
On Wed, 18 May 2022, Giuliano Belinassi wrote:
> On powerpc64le, the tests related to pr105169 failed because the
> .localentry was not on a power of two address due to the extra nop
> instruction taking one byte and thus moving its position one byte
> further. Generating two nops instead moves .localentry to a valid
> position.
OK
> gcc/testsuite/ChangeLog
> 2022-05-18 Giuliano Belinassi <gbelinassi@suse.de>
>
> PR target/105647
> * g++.dg/modules/pr105169_a.C: Change -fpatchable-function-entry to 2.
> * g++.dg/modules/pr105169_b.C: Likewise.
> ---
> gcc/testsuite/g++.dg/modules/pr105169_a.C | 4 ++--
> gcc/testsuite/g++.dg/modules/pr105169_b.C | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gcc/testsuite/g++.dg/modules/pr105169_a.C b/gcc/testsuite/g++.dg/modules/pr105169_a.C
> index 66dc4b7901f..02660b3a0e4 100644
> --- a/gcc/testsuite/g++.dg/modules/pr105169_a.C
> +++ b/gcc/testsuite/g++.dg/modules/pr105169_a.C
> @@ -1,6 +1,6 @@
> /* { dg-module-do link } */
> -/* { dg-options "-std=c++11 -fpatchable-function-entry=1 -O2" } */
> -/* { dg-additional-options "-std=c++11 -fpatchable-function-entry=1 -O2" } */
> +/* { dg-options "-std=c++11 -fpatchable-function-entry=2 -O2" } */
> +/* { dg-additional-options "-std=c++11 -fpatchable-function-entry=2 -O2" } */
>
> /* This test is in the "modules" package because it supports multiple files
> linkage. */
> diff --git a/gcc/testsuite/g++.dg/modules/pr105169_b.C b/gcc/testsuite/g++.dg/modules/pr105169_b.C
> index 5f8b00dfe51..7a9c5863a6a 100644
> --- a/gcc/testsuite/g++.dg/modules/pr105169_b.C
> +++ b/gcc/testsuite/g++.dg/modules/pr105169_b.C
> @@ -1,6 +1,6 @@
> /* { dg-module-do link } */
> -/* { dg-options "-std=c++11 -fpatchable-function-entry=1 -O2" } */
> -/* { dg-additional-options "-std=c++11 -fpatchable-function-entry=1 -O2" } */
> +/* { dg-options "-std=c++11 -fpatchable-function-entry=2 -O2" } */
> +/* { dg-additional-options "-std=c++11 -fpatchable-function-entry=2 -O2" } */
>
> /* This test is in the "modules" package because it supports multiple files
> linkage. */
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman;
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PR105647 Update pr105169* so it does not fail on powerpc64le
2022-05-19 6:34 ` [PATCH] PR105647 Update pr105169* so it does not fail on powerpc64le Richard Biener
@ 2022-05-19 13:01 ` Giuliano Belinassi
0 siblings, 0 replies; 2+ messages in thread
From: Giuliano Belinassi @ 2022-05-19 13:01 UTC (permalink / raw)
To: gbelinassi, rguenther; +Cc: gcc-patches, seurer, matz
On Thu, 2022-05-19 at 06:34 +0000, Richard Biener wrote:
> On Wed, 18 May 2022, Giuliano Belinassi wrote:
>
> > On powerpc64le, the tests related to pr105169 failed because the
> > .localentry was not on a power of two address due to the extra nop
> > instruction taking one byte and thus moving its position one byte
> > further. Generating two nops instead moves .localentry to a valid
> > position.
>
> OK
Pushed to trunk.
>
> > gcc/testsuite/ChangeLog
> > 2022-05-18 Giuliano Belinassi <gbelinassi@suse.de>
> >
> > PR target/105647
> > * g++.dg/modules/pr105169_a.C: Change -fpatchable-function-
> > entry to 2.
> > * g++.dg/modules/pr105169_b.C: Likewise.
> > ---
> > gcc/testsuite/g++.dg/modules/pr105169_a.C | 4 ++--
> > gcc/testsuite/g++.dg/modules/pr105169_b.C | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/gcc/testsuite/g++.dg/modules/pr105169_a.C
> > b/gcc/testsuite/g++.dg/modules/pr105169_a.C
> > index 66dc4b7901f..02660b3a0e4 100644
> > --- a/gcc/testsuite/g++.dg/modules/pr105169_a.C
> > +++ b/gcc/testsuite/g++.dg/modules/pr105169_a.C
> > @@ -1,6 +1,6 @@
> > /* { dg-module-do link } */
> > -/* { dg-options "-std=c++11 -fpatchable-function-entry=1 -O2" } */
> > -/* { dg-additional-options "-std=c++11 -fpatchable-function-
> > entry=1 -O2" } */
> > +/* { dg-options "-std=c++11 -fpatchable-function-entry=2 -O2" } */
> > +/* { dg-additional-options "-std=c++11 -fpatchable-function-
> > entry=2 -O2" } */
> >
> > /* This test is in the "modules" package because it supports
> > multiple files
> > linkage. */
> > diff --git a/gcc/testsuite/g++.dg/modules/pr105169_b.C
> > b/gcc/testsuite/g++.dg/modules/pr105169_b.C
> > index 5f8b00dfe51..7a9c5863a6a 100644
> > --- a/gcc/testsuite/g++.dg/modules/pr105169_b.C
> > +++ b/gcc/testsuite/g++.dg/modules/pr105169_b.C
> > @@ -1,6 +1,6 @@
> > /* { dg-module-do link } */
> > -/* { dg-options "-std=c++11 -fpatchable-function-entry=1 -O2" } */
> > -/* { dg-additional-options "-std=c++11 -fpatchable-function-
> > entry=1 -O2" } */
> > +/* { dg-options "-std=c++11 -fpatchable-function-entry=2 -O2" } */
> > +/* { dg-additional-options "-std=c++11 -fpatchable-function-
> > entry=2 -O2" } */
> >
> > /* This test is in the "modules" package because it supports
> > multiple files
> > linkage. */
> >
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-19 13:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220518193652.11699-1-gbelinassi@suse.de>
2022-05-19 6:34 ` [PATCH] PR105647 Update pr105169* so it does not fail on powerpc64le Richard Biener
2022-05-19 13:01 ` Giuliano Belinassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).