From: Jeff Law <jeffreyalaw@gmail.com>
To: Xi Ruoyao <xry111@mengyan1223.wang>,
YunQiang Su <yunqiang.su@cipunited.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libffi: Fix MIPS r6 support
Date: Sun, 29 Aug 2021 15:00:43 -0600 [thread overview]
Message-ID: <1101b9a3-3bfa-413a-7934-133dfa0d50a2@gmail.com> (raw)
In-Reply-To: <9a076d77fb2f1503b7f59c523b5e52ef7c859772.camel@mengyan1223.wang>
On 8/28/2021 1:23 AM, Xi Ruoyao wrote:
> On Fri, 2021-08-27 at 15:28 -0600, Jeff Law via Gcc-patches wrote:
>>
>> On 8/26/2021 10:58 PM, YunQiang Su wrote:
>>> for some instructions, MIPS r6 uses different encoding other than
>>> the previous releases.
>>>
>>> 1. mips/n32.S disable .set mips4: since it casuses old insn encoding
>>> is used.
>>> https://github.com/libffi/libffi/pull/396
>>> 2. mips/ffi.c: the encoding for JR is hardcoded: we need to use
>>> different value for r6 and pre-r6.
>>> https://github.com/libffi/libffi/pull/401
>>>
>>> libffi/
>>> PR libffi/83636
>>> * src/mips/n32.S: disable .set mips4
>>> * src/mips/ffi.c: use different JR encoding for r6.
>> These should go to the upstream libffi project. Once accepted there
>> you
>> can add them to GCC.
> Hi Jeff,
>
> The two PRs are already merged, and released since libffi-3.3.0 (now the
> upstream latest release is 3.4.2).
ACK. Thanks for confirming. It's always OK to cherrypick/backport from
libffi back to GCC.
>
> I don't have a MIPSr6 so I can't test though.
Understood. Me neither, but I really should get a tiny chroot for
mipsr6 so that my tester can validate it regularly.
Jeff
next prev parent reply other threads:[~2021-08-29 21:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 4:58 YunQiang Su
2021-08-27 21:28 ` Jeff Law
2021-08-28 7:23 ` Xi Ruoyao
2021-08-28 12:14 ` YunQiang Su
2021-08-29 21:00 ` Jeff Law [this message]
2021-08-30 8:47 ` YunQiang Su
2021-08-30 13:46 ` Jeff Law
2021-08-31 2:46 ` YunQiang Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101b9a3-3bfa-413a-7934-133dfa0d50a2@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=xry111@mengyan1223.wang \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).