From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 92A9E3858D35 for ; Tue, 22 Nov 2022 15:20:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 92A9E3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42f.google.com with SMTP id x66so6046074pfx.3 for ; Tue, 22 Nov 2022 07:20:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=imt8DNlDzLXnpRH1s4KPDiMkfugRrTqTvWw/5Xl4gtI=; b=HunZB/q/sSpTnvEB4rM1l01GL+Hws+J08DEZL/ufxMTpxiZjvJofZTF8qA/VoRhTTZ AlLrdkRCY3AlYadzzVtPbPDknRRCkWl8U9Dkr+azddu4cv7XnRpNkHPCvq2a7qJVqSfI jUC7Y0wkPBmcHlXRBp2FA5v7RoZQDNN3hyiy9tdiWKNSuqR7NeP/NXkyONXXJ+OC/dEe EsiPetW6KDdxifiIjIvqoXugrl558BKckkDeXaHg/kDINn99PPoo1y0nGNwaymxq6Yqq SlBrKTR/LcbwAAWkiyP9/cd/zGjmyXRWmGP6ymp1ioHNnwHhfMzuggaherBjpEbth3Cu OowA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=imt8DNlDzLXnpRH1s4KPDiMkfugRrTqTvWw/5Xl4gtI=; b=lL1ZsCpsCcM2D/uQpiCkVm+eJHG5zfKA8LhGgMeNMhUALe1BubyLZx4/lgXiygUN4W 6VxqRnVyzpBV1h3DCsYgoCh3Ief4oKef3BMCOXYZVZeFv0becJ6yjyNHoPSa5NgqHnox AzZr0wf7F36Awg4CNyK3FWRzuU+rLMh8zChCMNiJ8rr3id4Qhmy71hksr3I/V/bCjlb0 f4fh72U1mG4i0S4wfYh2TlsBCIBR6d7OCxc/lLihTWpMdUmVHUyoOMzjdi69uPnksPQy tpLKgy4NHk+vlHMkxsFZe+aV0mqgHpi/5DBuUdKNezn1H3jyOAfwe5segO77sq+qCmLf Hchg== X-Gm-Message-State: ANoB5plN68651TaAoIcvpsXNURmFLe/RlrKs7tEcP30ACN5GGyblmA4N 6BS8imnrCC4m2BLNk/AY6sk= X-Google-Smtp-Source: AA0mqf6beIcWnjQn3bMtd42Mzal0iElGRMMHhoNKckpbcBksON3wIu9r/qxsO7CI0ykhcUNpIAefVg== X-Received: by 2002:a63:d601:0:b0:442:eb8e:910 with SMTP id q1-20020a63d601000000b00442eb8e0910mr4314885pgg.97.1669130417368; Tue, 22 Nov 2022 07:20:17 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id t9-20020a170902b20900b0018099c9618esm12072115plr.231.2022.11.22.07.20.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 07:20:16 -0800 (PST) Message-ID: <113a2b0a-8b8a-3d6c-60ec-8d57cf7350f4@gmail.com> Date: Tue, 22 Nov 2022 08:20:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] RISC-V: Add the Zihpm and Zicntr extensions Content-Language: en-US To: Kito Cheng Cc: Palmer Dabbelt , gcc-patches@gcc.gnu.org References: <20221109030036.19175-1-palmer@rivosinc.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/20/22 18:36, Kito Cheng wrote: >> So the idea here is just to define the extension so that it gets defined >> in the ISA strings and passed through to the assembler, right? > That will also define arch test marco: > > https://github.com/riscv-non-isa/riscv-c-api-doc/blob/master/riscv-c-api.md#architecture-extension-test-macro Sorry I should have been clearer and included the test macro(s) as well. So a better summary would be that while it doesn't change the codegen behavior in the compiler, it does provide the mechanisms to pass along isa strings to other tools such as the assembler and signal via the test macros that this extension is available. If so I think that it meets Andrew's requirements and at least some of those issues raised by Jim.   But I'm not sure it can address your concern WRT consistency.  In fact, I don't really see a way to address that concern with option #2 which Andrew seems to think is the only reasonable path forward from an RVI standpoint. I'm at a loss for next steps, particularly as the newbie in this world. jeff