From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10179 invoked by alias); 13 Mar 2006 19:23:22 -0000 Received: (qmail 10171 invoked by uid 22791); 13 Mar 2006 19:23:21 -0000 X-Spam-Check-By: sourceware.org Received: from e34.co.us.ibm.com (HELO e34.co.us.ibm.com) (32.97.110.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 13 Mar 2006 19:23:20 +0000 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e34.co.us.ibm.com (8.12.11/8.12.11) with ESMTP id k2DJNGhE027288 for ; Mon, 13 Mar 2006 14:23:16 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.8) with ESMTP id k2DJKQIS265762 for ; Mon, 13 Mar 2006 12:20:26 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id k2DJNFjE001675 for ; Mon, 13 Mar 2006 12:23:16 -0700 Received: from linux-009047018077.beaverton.ibm.com (dyn9047018077.beaverton.ibm.com [9.47.18.77]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id k2DJNFF6001594; Mon, 13 Mar 2006 12:23:15 -0700 Received: by linux-009047018077.beaverton.ibm.com (Postfix, from userid 1000) id D16E2E999; Mon, 13 Mar 2006 11:27:06 -0800 (PST) Subject: Re: Patch ping From: Uttam Pawar To: Roger Sayle Cc: uttamp@us.ibm.com, gcc-patches@gcc.gnu.org In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Mon, 13 Mar 2006 19:23:00 -0000 Message-Id: <1142278025.18913.259.camel@linux.site> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2006-03/txt/msg00781.txt.bz2 Roger, Thanks for reviewing the patches and for your feedback. > The bt-load.c fix is OK, to close PR rtl-optimiztion/25739. > I think the other changes are suitably obvious enough, even if > not part of the middle-end, that I can approve them. Remember > to commit the version with the "if" checks before the calls to > free, and mention the above PR number in the ChangeLog entry. Here is a complete patch again. This has been regtest on powerpc64-linux with no new regressions. If it looks ok, could you commit it please, as I do not have commit access. Thanks, Uttam 2006-03-13 Uttam Pawar * gensupport.c (identify_predicable_attribute): Free p_false pointer. * gcov.c (create_file_names): Free name pointer. PR rtl-optimization/25739 * bt-load.c (augment_live_range): Free tos pointer. Index: gcc/gensupport.c =================================================================== *** gcc/gensupport.c (revision 111144) --- gcc/gensupport.c (working copy) *************** identify_predicable_attribute (void) *** 464,469 **** --- 464,471 ---- message_with_line (elem->lineno, "attribute `predicable' is not a boolean"); errors = 1; + if (p_false) + free (p_false); return; } p_true[-1] = '\0'; *************** identify_predicable_attribute (void) *** 481,492 **** --- 483,498 ---- message_with_line (elem->lineno, "attribute `predicable' cannot be const"); errors = 1; + if (p_false) + free (p_false); return; default: message_with_line (elem->lineno, "attribute `predicable' must have a constant default"); errors = 1; + if (p_false) + free (p_false); return; } *************** identify_predicable_attribute (void) *** 501,506 **** --- 507,515 ---- value); errors = 1; } + + if (p_false) + free (p_false); } /* Return the number of alternatives in constraint S. */ Index: gcc/gcov.c =================================================================== *** gcc/gcov.c (revision 111144) --- gcc/gcov.c (working copy) *************** create_file_names (const char *file_name *** 658,663 **** --- 658,664 ---- strcpy (da_file_name, name); strcpy (da_file_name + length, GCOV_DATA_SUFFIX); + free (name); return; } Index: gcc/bt-load.c =================================================================== *** gcc/bt-load.c (revision 111144) --- gcc/bt-load.c (working copy) *************** augment_live_range (bitmap live_range, H *** 911,916 **** --- 911,917 ---- { if (full_range) IOR_HARD_REG_SET (*btrs_live_in_range, btrs_live[new_bb->index]); + free (tos); return; } *tos++ = new_bb;