public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ben Elliston <bje@au1.ibm.com>
To: libstdc++@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org, iant@google.com
Subject: PATCH: fix warning in libstdc++/src/strstream.cc
Date: Thu, 04 Jan 2007 23:43:00 -0000	[thread overview]
Message-ID: <1167954163.24478.2.camel@localhost> (raw)

This new warning popped up as a result of some diagnostics work that I
think I saw mentioned in list traffic.  Committed as obvious.

2007-01-05  Ben Elliston  <bje@au.ibm.com>

        * src/strstream.cc (strstreambuf::seekoff): Add parentheses around
        truth expression to eliminate a new warning from g++.

Index: src/strstream.cc
===================================================================
--- src/strstream.cc    (revision 120450)
+++ src/strstream.cc    (working copy)
@@ -235,7 +235,7 @@ _GLIBCXX_BEGIN_NAMESPACE(std)
     if ((mode & (ios_base::in | ios_base::out)) 
        == (ios_base::in | ios_base::out) &&
        (dir == ios_base::beg || dir == ios_base::end))
-      do_get = do_put = true;
+      do_get = (do_put = true);
     else if (mode & ios_base::in)
       do_get = true;
     else if (mode & ios_base::out)


             reply	other threads:[~2007-01-04 23:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-04 23:43 Ben Elliston [this message]
2007-01-04 23:45 ` Andrew Pinski
2007-01-04 23:50   ` Ian Lance Taylor
2007-01-05  0:05     ` Ben Elliston
2007-01-04 23:51   ` Paolo Carlini
2007-01-05  2:30 ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1167954163.24478.2.camel@localhost \
    --to=bje@au1.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iant@google.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).