From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 224C53858D28 for ; Tue, 3 Oct 2023 08:23:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 224C53858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9b27f99a356so19789666b.0 for ; Tue, 03 Oct 2023 01:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696321409; x=1696926209; darn=gcc.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YwusW0oaprReei7WNENm/f4Z0MPbseUWudeBwbSiSqA=; b=N2VPQ6q4HZgV3j9czgiLVbCnqDE7gCh1N1eOXijHBiSJXmr9XYC6vVzdmCSTx67OL6 PRXRpU5hKC7/oATmMT7sp4u6Fk4u54WutO2jIRx2MzYwpc0ryN0w26knAX9QDG/3nNfp Nv6TvZKaa3LdzRsMHnHpNzxYgXST44j/ctxUUcGsFCzrgOtjbgRMcnN6ApnhNOAiTPBN TcC/iOg0XiHsZatU9aRpLKwL3lRy22fBHZrbGqhfYJUU7rti4h13BhPrQ1jITLJ9UFtj tg/myrFeaAqrqlTg/rqXHlxWRSt3T1qk9gR8GkCCrWhspSuSeos9yui8RbE3iT6swAbJ CoSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696321409; x=1696926209; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YwusW0oaprReei7WNENm/f4Z0MPbseUWudeBwbSiSqA=; b=Kld+UhObyEckalViOx6NbVj+drbUXVTtaYcUV7lPlRA59G5oVHdMuo8A5eS9M3fqWA u7h3YvjGl4OtvewhJf/NVo0MivpjRtTvLCpu9YOt0Vfw4nhnzp//80SiGBr+YYJ5oUZB wUyOeEWjwKeveAgvQWKZ5LfcrdLLkw2AL7uDWO9rTmCG4xd83Fn8S9Ro71xzEmrupbPL biYHV501VIkg166s7BUQgxIj5/g/iPBJ/wa6oOKozoj6lHddTskpxFuFsFdWN4I/FWtv DbJ236RGGGvnfLGcHyebqvE8R2YLgh0seHpQS45AnRLr3CbPBQ0u2z2BxjjrtzK3aUyl h+AQ== X-Gm-Message-State: AOJu0YzCfrs3Z7Hj6YwMx2IUJoQontLHwt+ufOuaFeK60XQQSWX8q5ER kyYb4V+DoC4U1S1/n1+ttF45 X-Google-Smtp-Source: AGHT+IEjBxKvwcFrTyLv4NETSBbgyqFf61duRfS5UIb+lkgkbsl9QuIzHsDWQz7jiKKklLpupYmUYg== X-Received: by 2002:a17:906:5185:b0:9ae:50de:1aaf with SMTP id y5-20020a170906518500b009ae50de1aafmr12057674ejk.4.1696321408567; Tue, 03 Oct 2023 01:23:28 -0700 (PDT) Received: from smtpclient.apple ([37.252.81.6]) by smtp.gmail.com with ESMTPSA id a16-20020a1709064a5000b009b27d4153c0sm656835ejv.178.2023.10.03.01.23.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Oct 2023 01:23:27 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: [PATCH v2] ARM: Block predication on atomics [PR111235] From: Maxim Kuvyrkov In-Reply-To: Date: Tue, 3 Oct 2023 12:23:16 +0400 Cc: Wilco Dijkstra , Richard Earnshaw , Kyrylo Tkachov , GCC Patches , linaro-toolchain@lists.linaro.org Content-Transfer-Encoding: quoted-printable Message-Id: <117056FE-2297-498A-AF1B-93B108E35916@linaro.org> References: To: Ramana Radhakrishnan X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Oct 1, 2023, at 00:36, Ramana Radhakrishnan = wrote: >=20 > + linaro-toolchain as I don't understand the CI issues on patchwork. >=20 >=20 ... > Ok if no regressions but as you might get nagged by the post commit CI = ... I don't see any pre-commit failures for this patch, but regardless of = what results are for pre-commit CI, there's always a chance to identify = problems in post-commit CI -- simply because we test wa-a-ay more = configurations in post-commit CI than in pre-commit CI. >=20 > While it is not policy yet to look at these bots but given the > enthusiasm at Cauldron for patchwork and pre-commit CI and because all > my armhf boxes are boxed up, I decided to do something a bit novel ! >=20 > I tried reviewing this via patchwork >=20 > = https://patchwork.sourceware.org/project/gcc/patch/PAWPR08MB8982A6AA40749B= 74CAD14C5783EEA@PAWPR08MB8982.eurprd08.prod.outlook.com/ >=20 > and notice that >=20 > = https://ci.linaro.org/job/tcwg_gcc_build--master-arm-precommit/2393/artifa= ct/artifacts/artifacts.precommit/notify/mail-body.txt > says nothing could be built. Um, no. This says ... =3D=3D=3D Results changed to # reset_artifacts: -10 # true: 0 # build_abe gcc: 1 From # reset_artifacts: -10 # true: 0 # build_abe gcc: 1 =3D=3D=3D ... i.e., build succeeded both before and after patch. We'll change the = boilerplate intro for successful builds from ... "Dear contributor, our automatic CI has detected problems related to = your patch(es)." ... to ... "Dear contributor, you are awesome, no CI failures related to your = patch(es)". One things that is strange -- testsuite builds were not triggered, we = have only 2 reports from build tests, but are missing another 2 reports = from testsuite tests. >=20 > Possibly worth double checking the status for it being a false > negative as to why the build failed. Pre-commit CI is happy with the patch, albeit testsuite checks didn't = run for some reason. Regardless, we'll quickly catch and report any = fallout in the post-commit CI once the patch is merged. >=20 > It was green on patchwork but remembering that Green is not Green for > CI in patchwork I clicked on the afore mentioned ci.linaro.org link > and see that it's actually broken. Unfortunately, I seem to have confused developers about green and red at = my Cauldron presentation. "Green/Red" in patchwork mean the usual = PASS/FAIL. It's only in post-commit CI in jenkins interface green and = red mean something different. -- Maxim Kuvyrkov https://www.linaro.org