From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14754 invoked by alias); 17 May 2007 23:44:55 -0000 Received: (qmail 14746 invoked by uid 22791); 17 May 2007 23:44:55 -0000 X-Spam-Check-By: sourceware.org Received: from out1.smtp.messagingengine.com (HELO out1.smtp.messagingengine.com) (66.111.4.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 May 2007 23:44:52 +0000 Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 2BDC32203BC; Thu, 17 May 2007 19:46:27 -0400 (EDT) Received: from web6.messagingengine.com ([10.202.2.215]) by compute2.internal (MEProxy); Thu, 17 May 2007 19:44:49 -0400 Received: by web6.messagingengine.com (Postfix, from userid 99) id F1C2B1134C; Thu, 17 May 2007 19:44:48 -0400 (EDT) Message-Id: <1179445488.20378.1190437705@webmail.messagingengine.com> From: libtool@cwilson.fastmail.fm To: "Steve Ellcey" Cc: bonzini@gnu.org, newlib@sourceware.org, aoliva@redhat.com, gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org Content-Disposition: inline Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="ISO-8859-1" MIME-Version: 1.0 X-Mailer: MessagingEngine.com Webmail Interface Subject: Re: Patch to update libtool in GCC and Src trees In-Reply-To: <200705172103.OAA10817@hpsje.cup.hp.com> Date: Thu, 17 May 2007 23:44:00 -0000 References: <200705172103.OAA10817@hpsje.cup.hp.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-05/txt/msg01173.txt.bz2 [adding the lists back] On Thu, 17 May 2007 14:03:34 -0700 (PDT), "Steve Ellcey" > Chuck, I am confused by your inclusion of 'compile' in the package. > Looking at my trees, I already see compile in the top-level of the GCC > and src tree's and it is the same version that you sent me. Well, that's really odd. My src checkout didn't contain it, but looking at viewCVS (src tree) and viewSVN (gcc tree) I see that, as you say, it is there and it is the same version. I wonder if it is a module definition thing: if you do a checkout winsup or checkout newlib, maybe you don't get all the files in toplevel? Hmm, it appears that the module definitions are going to need updating as part of your patch: http://cygwin.com/cgi-bin/cvsweb.cgi/CVSROOT/modules?rev=1.65&content-type=text/x-cvsweb-markup&cvsroot=src If you check out the entire src/ tree, you get all the contents of , including compile. OTOH, if you check out any explicit module (binutils, or newlib, or winsup) like I did, they all rely on the src-support module to get the necessary toplevel crud. But: the src-support module definition does NOT contain compile! Hence, I was missing compile, and thought it needed to be added. But what's really happened is that we've discovered a bug in the src tree: the module definition for src-support needs to list 'compile'. With your patch, it will also need to list ltversion.m4, ltoptions.m4, and ltsugar.m4. Module definitions are not versioned. It seems to me that the module definition should list ALL possible files that EVER were part of the module; if they've been deleted or were never added for your particular branch you just won't see them on checkout. Evidence for this: the 'src-support' module currently includes both "configure.in" and "configure.ac" -- but only one exists in any given branch. I don't know how SVN deals with modules, if it even supports them, or whether the gcc tree exhibits any problem similar to that observed here in the src tree. -- Chuck