From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26332 invoked by alias); 24 Jul 2007 21:25:48 -0000 Received: (qmail 26321 invoked by uid 22791); 24 Jul 2007 21:25:47 -0000 X-Spam-Check-By: sourceware.org Received: from e1.ny.us.ibm.com (HELO e1.ny.us.ibm.com) (32.97.182.141) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Jul 2007 21:25:46 +0000 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e1.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l6OLPiWb017513 for ; Tue, 24 Jul 2007 17:25:44 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.4) with ESMTP id l6OLPimm485528 for ; Tue, 24 Jul 2007 17:25:44 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l6OLPhtO012450 for ; Tue, 24 Jul 2007 17:25:44 -0400 Received: from [9.47.18.74] (dyn9047018074.beaverton.ibm.com [9.47.18.74]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l6OLPhnw012427; Tue, 24 Jul 2007 17:25:43 -0400 Subject: Re: [PATCH 5/5][testsuite] Use stdint.h when needing int of exact size From: Janis Johnson Reply-To: janis187@us.ibm.com To: Rask Ingemann Lambertsen Cc: gcc-patches@gcc.gnu.org In-Reply-To: <20070724172453.GG4125@sygehus.dk> References: <20070724160434.GB4125@sygehus.dk> <20070724172453.GG4125@sygehus.dk> Content-Type: text/plain Date: Tue, 24 Jul 2007 21:36:00 -0000 Message-Id: <1185312344.5814.20.camel@janis-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg01780.txt.bz2 On Tue, 2007-07-24 at 19:24 +0200, Rask Ingemann Lambertsen wrote: > These testcases all rely on very specific integer sizes to pass. The > vector tests assume the vectors have exactly four elements and simd-4.c > additionally needs integers of exactly 32 bits and 64 bits. pr27743.c relies > on sign extension of bit 31, so a signed 32-bit integer is required. This > patch uses types from stdint.h to make sure that these requirements are > met, also on targets where int gives you only 16 bits. > > Ok for trunk? > > :ADDPATCH testsuite: > > 2007-07-24 Rask Ingemann Lambertsen > > * gcc.dg/torture/pr27743.c (bar): Use an integer of exactly 32 bits > where required. > * gcc.c-torture/execute/simd-1.c: Likewise. > * gcc.c-torture/execute/pr23135.c: Likewise. > * gcc.c-torture/execute/simd-4.c (__ev_convert_s64)(main): Likewise. > Use an integer of exactly 64 bits where required. I agree with Andrew Pinski that you shouldn't change SImode in these tests; it would be better to skip them for targets that are not ILP32 or LP64. It's also not right to change the return value of main to something other than int, so I'd recommend also skipping that one if not ILP32 or LP64. Janis