From: Janis Johnson <janis187@us.ibm.com>
To: "H.J. Lu" <hjl@lucon.org>
Cc: gcc-patches@gcc.gnu.org, echristo@apple.com
Subject: Re: PATCH: PR testsuite/32932: ssp tests can't find libssp
Date: Tue, 31 Jul 2007 17:53:00 -0000 [thread overview]
Message-ID: <1185903836.6581.15.camel@janis-laptop> (raw)
In-Reply-To: <20070730230359.GA13062@lucon.org>
On Mon, 2007-07-30 at 16:03 -0700, H.J. Lu wrote:
> This patch makes sure that the newly built libssp is used for
> test. Tested on Linux/x86-64.
The patch doesn't handle multilibs; apparently you didn't test
with both -m32 and -m64.
These tests really ought to be in libssp/testsuite, which doesn't
yet exist, and look for libraries in the same way as other library
testsuites. I've copied Eric Christopher, who added these tests,
to get his opinion about that.
Setting gcc_initialized doesn't belong in this patch, and should
be tested by running the full testsuite with multiple runs, e.g.
-m32 and -m64, to make sure there are no surprises.
Janis
next prev parent reply other threads:[~2007-07-31 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 0:46 H.J. Lu
2007-07-31 17:53 ` Janis Johnson [this message]
2007-07-31 18:40 ` H.J. Lu
2007-07-31 21:31 ` Janis Johnson
2007-07-31 18:45 ` PATCH: gcc/testsuite: Set gcc_initialized to 1 H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185903836.6581.15.camel@janis-laptop \
--to=janis187@us.ibm.com \
--cc=echristo@apple.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl@lucon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).