From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4851 invoked by alias); 31 Jul 2007 17:44:07 -0000 Received: (qmail 4836 invoked by uid 22791); 31 Jul 2007 17:44:06 -0000 X-Spam-Check-By: sourceware.org Received: from e4.ny.us.ibm.com (HELO e4.ny.us.ibm.com) (32.97.182.144) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 31 Jul 2007 17:44:00 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l6VHhvgK016797 for ; Tue, 31 Jul 2007 13:43:57 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.4) with ESMTP id l6VHhvK8539362 for ; Tue, 31 Jul 2007 13:43:57 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l6VHhveT022526 for ; Tue, 31 Jul 2007 13:43:57 -0400 Received: from [9.47.18.89] (dyn9047018089.beaverton.ibm.com [9.47.18.89]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l6VHhudm022515; Tue, 31 Jul 2007 13:43:56 -0400 Subject: Re: PATCH: PR testsuite/32932: ssp tests can't find libssp From: Janis Johnson Reply-To: janis187@us.ibm.com To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org, echristo@apple.com In-Reply-To: <20070730230359.GA13062@lucon.org> References: <20070730230359.GA13062@lucon.org> Content-Type: text/plain Date: Tue, 31 Jul 2007 17:53:00 -0000 Message-Id: <1185903836.6581.15.camel@janis-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg02194.txt.bz2 On Mon, 2007-07-30 at 16:03 -0700, H.J. Lu wrote: > This patch makes sure that the newly built libssp is used for > test. Tested on Linux/x86-64. The patch doesn't handle multilibs; apparently you didn't test with both -m32 and -m64. These tests really ought to be in libssp/testsuite, which doesn't yet exist, and look for libraries in the same way as other library testsuites. I've copied Eric Christopher, who added these tests, to get his opinion about that. Setting gcc_initialized doesn't belong in this patch, and should be tested by running the full testsuite with multiple runs, e.g. -m32 and -m64, to make sure there are no surprises. Janis