From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17060 invoked by alias); 31 Jul 2007 20:52:55 -0000 Received: (qmail 17037 invoked by uid 22791); 31 Jul 2007 20:52:53 -0000 X-Spam-Check-By: sourceware.org Received: from e5.ny.us.ibm.com (HELO e5.ny.us.ibm.com) (32.97.182.145) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 31 Jul 2007 20:52:47 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e5.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l6VKqhPo001851 for ; Tue, 31 Jul 2007 16:52:43 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.4) with ESMTP id l6VKqhvU539378 for ; Tue, 31 Jul 2007 16:52:43 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l6VKqhJP009982 for ; Tue, 31 Jul 2007 16:52:43 -0400 Received: from [9.47.18.89] (dyn9047018089.beaverton.ibm.com [9.47.18.89]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l6VKqg8U009953; Tue, 31 Jul 2007 16:52:42 -0400 Subject: Re: PATCH: PR testsuite/32932: ssp tests can't find libssp From: Janis Johnson Reply-To: janis187@us.ibm.com To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org, echristo@apple.com In-Reply-To: <20070731182001.GA28810@lucon.org> References: <20070730230359.GA13062@lucon.org> <1185903836.6581.15.camel@janis-laptop> <20070731182001.GA28810@lucon.org> Content-Type: text/plain Date: Tue, 31 Jul 2007 21:31:00 -0000 Message-Id: <1185915163.6581.21.camel@janis-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg02206.txt.bz2 On Tue, 2007-07-31 at 11:20 -0700, H.J. Lu wrote: > On Tue, Jul 31, 2007 at 10:43:56AM -0700, Janis Johnson wrote: > > On Mon, 2007-07-30 at 16:03 -0700, H.J. Lu wrote: > > > This patch makes sure that the newly built libssp is used for > > > test. Tested on Linux/x86-64. > > > > The patch doesn't handle multilibs; apparently you didn't test > > with both -m32 and -m64. > > It does support multilibs: > > @@ -113,6 +114,10 @@ proc gcc_init { args } { > set gcc_error_prefix "error:" > > gcc_maybe_build_wrapper "${tmpdir}/gcc-testglue.o" > + > + libssp_init [get_multilibs] But libssp_init only processes the first one; see how they're handled for libmudflap, for example, to add all of them to LD_LIBRARY_PATH. > and I tested with -m32 on Linux/x86-64: > > Executing on host: /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc > -B/export/build/gnu/gcc/build-x86_64-linux/gcc/ > /export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/ssp-1.c -fstack-protector -fno-show-column > -L/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs > -lm -m32 -o ./ssp-1.exe (timeout = 300) This uses the 32-bit library for -m32, and adds it to LD_LIBRARY_PATH > Executing on host: /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc > -B/export/build/gnu/gcc/build-x86_64-linux/gcc/ > /export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/ssp-1.c > -fstack-protector -fno-show-column > -L/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs > -lm -o ./ssp-1.exe (timeout = 300) This uses the 32-bit library for the default and adds the 32-bit library to LD_LIBRARY_PATH. Janis