On 17/06/2022 11:54, Richard Sandiford wrote:
> "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com> writes:
>> Hi,
>>
>> This patch adds support for the ACLE Data Intrinsics to the AArch64 port.
>>
>> Bootstrapped and regression tested on aarch64-none-linux.
>>
>> OK for trunk?
> Sorry for the slow review.
No worries :)
>
>> +{								      \
>> +  size_t size = sizeof (TYPE) * __CHAR_BIT__;			      \
>> +  rotate = rotate % size;					      \
>> +  return value >> rotate | value << (size - rotate);		      \
> This runs into UB for rotate == 0.
I assume it's because of the value << size no? I added a modulo, I 
assume it's legal to shift by 0?

This OK?