From: FX Coudert <fxcoudert@gmail.com>
To: Richard Biener <rguenther@suse.de>
Cc: Jakub Jelinek <jakub@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
dmalcolm@redhat.com, Iain Sandoe <iain@sandoe.co.uk>,
Eric Gallager <egall@gwmail.gwu.edu>,
josmyers@redhat.com
Subject: Re: [PATCH] jit: Ensure ssize_t is defined.
Date: Fri, 28 Jun 2024 09:15:59 +0200 [thread overview]
Message-ID: <1199018C-EF03-4BA6-A142-C74BE086874A@gmail.com> (raw)
In-Reply-To: <r72nq303-qs35-7032-q9so-496r0oq48695@fhfr.qr>
> But isn't the bigger issue that sys/types.h isn't guaranteed to contain
> a declaration of ssize_t? And that when sys/types.h isn't available
> we don't get ssize_t from it either?
Some targets seem to get it indirectly from stdio.h
As far as I know, darwin is the only platform broken currently, and the patch is definitely an improvement there.
> That said, maybe we're fine with this but then I walk back and say
> just unconditionally include sys/types.h ...
It is included unconditionally in other headers, yes.
> Should be Davids say as he added this API.
Agreed, but a version of the patch was original proposed in January by Iain Sandoe, and I have proposed and pinged another version since May 2nd, and got no response from him. It is breaking build on a
FX
next prev parent reply other threads:[~2024-06-28 7:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 19:48 FX Coudert
2024-05-11 15:16 ` FX Coudert
2024-05-26 15:35 ` FX Coudert
2024-06-01 16:44 ` FX Coudert
2024-06-11 6:06 ` FX Coudert
2024-06-11 7:27 ` Richard Biener
2024-06-11 7:44 ` Jakub Jelinek
2024-06-11 8:03 ` Iain Sandoe
2024-06-11 8:04 ` Richard Biener
2024-06-11 8:06 ` Richard Biener
2024-06-11 8:16 ` Iain Sandoe
2024-06-11 8:34 ` Andreas Schwab
2024-06-11 8:20 ` Jakub Jelinek
2024-06-11 8:21 ` Andreas Schwab
2024-06-27 17:08 ` FX Coudert
2024-06-28 6:17 ` Richard Biener
2024-06-28 7:15 ` FX Coudert [this message]
2024-09-07 17:35 ` FX Coudert
2024-09-18 10:28 ` FX Coudert
2024-09-18 10:53 ` Richard Biener
2024-09-18 17:53 ` FX Coudert
2024-06-11 8:21 ` FX Coudert
2024-06-11 7:20 ` Xi Ruoyao
-- strict thread matches above, loose matches on Subject: below --
2024-01-28 11:44 Iain Sandoe
2024-01-28 21:25 ` Eric Gallager
2024-01-28 23:13 ` Iain Sandoe
2024-01-29 11:26 ` Iain Sandoe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199018C-EF03-4BA6-A142-C74BE086874A@gmail.com \
--to=fxcoudert@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=egall@gwmail.gwu.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=jakub@redhat.com \
--cc=josmyers@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).