From: Simon Wright <simon@pushface.org>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] fix PR ada/80888
Date: Fri, 16 Jun 2017 16:58:00 -0000 [thread overview]
Message-ID: <11CD452A-4512-4E34-8797-F33EBED6FCF8@pushface.org> (raw)
In-Reply-To: <AEE97DB2-397E-44DA-8C85-3BA867F824A1@pushface.org>
Ping
If OK, can it be applied please?
(patch applies cleanly to current sources)
> On 27 May 2017, at 16:58, Simon Wright <simon@pushface.org> wrote:
>
> The GNAT reference manual says in 11.6 Wide_Text_IO
> <https://gcc.gnu.org/onlinedocs/gnat_rm/Wide_005fText_005fIO.html>,
>
> "The default encoding method for the standard files, and for opened
> files for which no WCEM parameter is given in the FORM string matches
> the wide character encoding specified for the main program (the
> default being brackets encoding if no coding method was specified with
> -gnatW)."
>
> This is not true; the default is brackets encoding regardless of the
> coding method specified with -gnatW.
>
> The attached patch (to 7.1.0) corrects this. Tested on
> x86_84-apple-darwin15 by rebuilding the library (cd gcc; make gnatlib
> gnatlib-shared) and make -j4 check-ada,
>
> === acats Summary ===
> # of expected passes 2320
> # of unexpected failures 0
> /Volumes/Miscellaneous/tmp/gcc-7.1.0/gcc/testsuite/ada/acats/run_all.sh completed at Fri 26 May 2017 15:44:52 BST
>
> === gnat Summary ===
>
> # of expected passes 2569
> # of expected failures 24
> # of unsupported tests 7
> /Volumes/Miscellaneous/tmp/gcc-7.1.0-build/gcc/gnatmake version 7.1.0
>
> gcc/ada/Changelog:
>
> 2017-05-27 Simon Wright <simon@pushface.org>
>
> PR ada/80888
> * a-textio.adb (Set_WCEM): default the file's wide character encoding
> method to Default_WCEM, not WCEM_Brackets.
> * a-witeio.adb: likewise.
> * a-ztexio.adb: likewise.
>
> <wcem-fix.diff>
next prev parent reply other threads:[~2017-06-16 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 18:35 Simon Wright
2017-06-16 16:58 ` Simon Wright [this message]
2017-06-18 13:08 ` Arnaud Charlet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11CD452A-4512-4E34-8797-F33EBED6FCF8@pushface.org \
--to=simon@pushface.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).