From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-455851-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 124861 invoked by alias); 13 Jun 2017 13:59:33 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 124744 invoked by uid 89); 13 Jun 2017 13:59:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.suse.de
Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 13:59:31 +0000
Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx1.suse.de (Postfix) with ESMTP id 7DF46AE4D;	Tue, 13 Jun 2017 13:59:33 +0000 (UTC)
Subject: Re: [PATCH v2] Implement no_sanitize function attribute
To: Richard Biener <richard.guenther@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>, "Joseph S. Myers" <joseph@codesourcery.com>, GCC Patches <gcc-patches@gcc.gnu.org>
References: <83f8580a-03e1-81eb-3216-a1c998810b90@suse.cz> <58587d2d-f61b-e6d5-2d59-8520ca0ce59f@suse.cz> <CAFiYyc1Xd-jTFhBGw7H80PLcqbTbgnuhprCQyZgn-h9i9QmVbw@mail.gmail.com> <7a8c52c8-5547-e3f2-02d1-9bc00e69d313@suse.cz> <20170608134715.GV2154@tucnak> <d208611e-d0cf-bdaf-3874-8d3e9d7bf1ce@suse.cz> <CAFiYyc2KKbiToi7Q=TOkCa0ueCQChGsrHS5+akw8ng7CLxnKKQ@mail.gmail.com> <6a27b454-a2a7-ff42-f5b3-93690ca0cf05@suse.cz> <CAFiYyc0NXtaOTeMHe6YL9L4GFufn6cOJePB0fDgfYfVdwh4NYw@mail.gmail.com> <827faf71-693f-cd1b-3e67-212d9048ed65@suse.cz> <CAFiYyc09ummxo8nfon-babmU9R3_Eh8ib1n9M=4jcVUEm_Zd_A@mail.gmail.com> <2a875298-ecbc-8ef2-991c-7018b82a309a@suse.cz> <CAFiYyc39hXd4VLeAEvbG-vbeBWWp+fHar=FSBuW1V8K2hjs_Ew@mail.gmail.com> <32e841e7-6b3e-5c48-3d83-e93150c4a71e@suse.cz> <CAFiYyc1Sd_scr1p8ksDHZryF+svt+hrfXawC7O5OA-NsKDiY=A@mail.gmail.com> <dc4e98a7-3003-f255-d6a6-906cd0944ef5@suse.cz> <CAFiYyc1SNgBLR7JXKQ+To9r48ca+QjfC=txEm4D3xQhVRrN5UQ@mail.gmail.com>
From: =?UTF-8?Q?Martin_Li=c5=a1ka?= <mliska@suse.cz>
Message-ID: <11a43f7a-7c27-2223-f892-e6aba4bccc15@suse.cz>
Date: Tue, 13 Jun 2017 13:59:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CAFiYyc1SNgBLR7JXKQ+To9r48ca+QjfC=txEm4D3xQhVRrN5UQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
X-SW-Source: 2017-06/txt/msg00946.txt.bz2

On 06/13/2017 03:49 PM, Richard Biener wrote:
> On Tue, Jun 13, 2017 at 1:09 PM, Martin Liška <mliska@suse.cz> wrote:
>> On 06/09/2017 03:35 PM, Richard Biener wrote:
>>> You can directly transform to no_sanitize with integer mask, not sure why
>>> you'd need an intermediate step with a string?
>>
>> Hello.
>>
>> Done in attached patch, I'm sending both incremental and final version (complete patch).
>> I also decided to support no_sanitize attribute in pretty printer:
>>
>> __attribute__((no_sanitize (address | shift | shift-base | shift-exponent | integer-divide-by-zero | undefined | unreachable | vla-bound | return | null | signed-integer-overflow | bool | enum | float-divide-by-zero | float-cast-overflow | bounds | bounds-strict | alignment | nonnull-attribute | returns-nonnull-attribute | object-size | vptr)))
>> fn1 ()
>> {
>>   char my_char[9];
>>   char * ptr2;
>>   char * ptr;
>> ..
>>
>>
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>
>> Ready to be installed?
> 
> 
> +unsigned int
> +parse_no_sanitize_attribute (char *value, char **wrong_argument)
> +{
> 
> functions need a comment.
> 
> Otherwise looks ok to me.

Done and patch installed as r249158.

Thanks for help with that.
Martin

> 
> Thanks,
> Richard.
> 
>> Martin