From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id C18FB3858C52; Mon, 10 Apr 2023 09:27:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C18FB3858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33A6rf6S022972; Mon, 10 Apr 2023 09:27:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=UTeG+w0sZi+aVV+Ody7XlHqmKNNBPsG3g6Oga2CMHHI=; b=Fkklor1Pk3TISyEl6cR3JPSbaMvp1xdk5cypbGVhne/Rawp8B2ZKvKJHKXgU0XtzusDA R1+kjylbYY44aoLX83qDj2pmQBwq3xNzIiPMYvZWc0M+BHI15u6a+QiMJD8WmdlUx/O5 lmSFdXi+7TD5hyTuBRPcjsU4ajjX+ZHZ01p+cXdOjYVF9Roj/DLcIf762WnKmXvjd/Uf RVnF+jSjXJZRrJlTmtb7TC12F1SXC9EOf0AorpGnkv9pj144RgJKVGxdj5fOJ88jSeCJ AYGRZBgQnpTklxeG4IMZwAcc8p1/5BDcrH00sc69sg4cSzjOV9RU3eIjMsKYDPUnK7BO yQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3puj1f38h4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Apr 2023 09:27:01 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33A9LjbR008154; Mon, 10 Apr 2023 09:27:00 GMT Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3puj1f38d5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Apr 2023 09:27:00 +0000 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33A7qmLP005741; Mon, 10 Apr 2023 09:26:38 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma06fra.de.ibm.com (PPS) with ESMTPS id 3pu0hq0u9j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Apr 2023 09:26:38 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33A9QZMa28050072 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Apr 2023 09:26:35 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 02C3C20040; Mon, 10 Apr 2023 09:26:35 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 315AA2004D; Mon, 10 Apr 2023 09:26:32 +0000 (GMT) Received: from [9.177.10.50] (unknown [9.177.10.50]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 10 Apr 2023 09:26:31 +0000 (GMT) Message-ID: <11b29ca1-cd23-1a48-4ad8-3b472d38fd2f@linux.ibm.com> Date: Mon, 10 Apr 2023 17:26:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] testsuite: update requires for powerpc/float128-cmp2-runnable.c Content-Language: en-US To: Jiufu Guo Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, meissner@linux.ibm.com, gcc-patches@gcc.gnu.org References: <20230410020941.2440885-1-guojiufu@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <20230410020941.2440885-1-guojiufu@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: zf1pPYm2q3tM76NxX7NaOag47s7p9Jpu X-Proofpoint-GUID: m1-rXA9Cxs_viOOJOqJRx55YnMmvfgRW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-10_06,2023-04-06_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 adultscore=0 impostorscore=0 mlxlogscore=999 phishscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304100078 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff, on 2023/4/10 10:09, Jiufu Guo via Gcc-patches wrote: > Hi, > > In this test case (float128-cmp2-runnable.c), the instruction > xscmpexpqp is used to support a few builtins e.g. > __builtin_vsx_scalar_cmp_exp_qp_eq on _Float128. > This instruction handles the whole 128bits of the vector, and > it is guarded by [ieee128-hw]. The instruction xscmpexpqp is guarded with TARGET_P9_VECTOR, (define_insn "*xscmpexpqp" [(set (match_operand:CCFP 0 "cc_reg_operand" "=y") (compare:CCFP (unspec:IEEE128 [(match_operand:IEEE128 1 "altivec_register_operand" "v") (match_operand:IEEE128 2 "altivec_register_operand" "v")] UNSPEC_VSX_SCMPEXPQP) (match_operand:SI 3 "zero_constant" "j")))] "TARGET_P9_VECTOR" "xscmpexpqp %0,%1,%2" [(set_attr "type" "fpcompare")]) [ieee128-hw] is used for guarding those bifs, so the above statement doesn't quite match the fact. PR108758 said this case doesn't fail with gcc-10 and gcc-11, I wonder why it changes from gcc-12? The above define_insn shows the underlying insns for these bifs just requires the condition power9-vector. Could you have a further check? Thanks. btw, please add a PR marker for PR108758. BR, Kewen > So, we may update the testcase to require ppc_float128_hw. > > Tested on ppc64 both BE and LE. > Is this ok for trunk? > > BR, > Jeff (Jiufu) > > gcc/testsuite/ChangeLog: > > * gcc.target/powerpc/float128-cmp2-runnable.c: Update requires. > > --- > gcc/testsuite/gcc.target/powerpc/float128-cmp2-runnable.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/powerpc/float128-cmp2-runnable.c b/gcc/testsuite/gcc.target/powerpc/float128-cmp2-runnable.c > index d376a3ca68e..91287c0fb7a 100644 > --- a/gcc/testsuite/gcc.target/powerpc/float128-cmp2-runnable.c > +++ b/gcc/testsuite/gcc.target/powerpc/float128-cmp2-runnable.c > @@ -1,5 +1,5 @@ > /* { dg-do run } */ > -/* { dg-require-effective-target ppc_float128_sw } */ > +/* { dg-require-effective-target ppc_float128_hw } */ > /* { dg-require-effective-target p9vector_hw } */ > /* { dg-options "-O2 -mdejagnu-cpu=power9 " } */ >