public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jerry DeLisle <jvdelisle@verizon.net>
To: Tobias Burnus <tobias.burnus@physik.fu-berlin.de>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [patch, fortran]PR25829 Add support for F2003 I/O features
Date: Sat, 05 Apr 2008 16:30:00 -0000	[thread overview]
Message-ID: <1207409043.2963.17.camel@lenova.localdomain> (raw)
In-Reply-To: <20080405113248.GA30275@physik.fu-berlin.de>


On Sat, 2008-04-05 at 13:32 +0200, Tobias Burnus wrote:
> Hi Jerry,
> 
> > The patch is getting too big so i do not want to add any more until we
> > get this in trunk,
> > With that said, I have attached the latest patch and 7 new test cases.
> > OK for trunk.
> 
> I think the patch is OK.
> 
> I added some more items below, but they can be fixed later.
> (a), (b) and (c) are relatively simply, (d) needs more effort.
> And (e) can be postponed or included in the (a) to (c) patch.
> 
Yes all of these of course.  Most should be straight forward at this
point.  It takes some tedium to do.  An example to watch out for is the
sign status mechanism.  There are two different enumerators being used.
The original is embedded in the dtp structure. The other is unit_sign in
io.h. The unit_sign is the way to go, however, if it is not ordered
correctly, things break. (I will add that it took some time to figure
that out) Fixing this is on my list.

I plan to commit the patch after the following:

1) clean up ChangeLogs
2) Version the st_wait symbol
3) Cross test the libraries with 4.3

After the commit, I will start on the items identified by Tobias.

Thanks for review and test case examples.

Jerry

  reply	other threads:[~2008-04-05 15:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-05 12:21 Tobias Burnus
2008-04-05 16:30 ` Jerry DeLisle [this message]
2008-04-05 17:31   ` NightStrike
2008-04-05 17:58     ` Jerry DeLisle
     [not found]   ` <47F7FE02.3070407@net-b.de>
     [not found]     ` <1207454811.15229.2.camel@lenova.localdomain>
2008-04-06 10:00       ` Tobias Burnus
  -- strict thread matches above, loose matches on Subject: below --
2008-04-01 21:10 Tobias Burnus
2008-04-04  4:53 ` Jerry DeLisle
2008-03-29 17:45 Tobias Burnus
2008-03-29 19:57 ` Jerry DeLisle
2008-04-01  4:31 ` Jerry DeLisle
2008-04-01 11:47   ` Tobias Burnus
2008-04-01 14:15     ` Jerry DeLisle
     [not found]       ` <47F494AC.30003@net-b.de>
2008-04-05  9:24         ` Jerry DeLisle
2008-04-05  9:27           ` Jerry DeLisle
2008-04-01 14:15     ` Jerry DeLisle
2008-03-16 21:48 Jerry DeLisle
2008-03-16 22:03 ` FX Coudert
2008-03-17  0:25   ` Jerry DeLisle
2008-03-17  7:52     ` Janne Blomqvist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207409043.2963.17.camel@lenova.localdomain \
    --to=jvdelisle@verizon.net \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tobias.burnus@physik.fu-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).