From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4815 invoked by alias); 5 Apr 2008 15:24:40 -0000 Received: (qmail 4799 invoked by uid 22791); 5 Apr 2008 15:24:39 -0000 X-Spam-Check-By: sourceware.org Received: from vms173003pub.verizon.net (HELO vms173003pub.verizon.net) (206.46.173.3) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 05 Apr 2008 15:24:20 +0000 Received: from [192.168.1.5] ([71.120.231.15]) by vms173003.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JYU00CJLYNCB0O4@vms173003.mailsrvcs.net>; Sat, 05 Apr 2008 10:21:13 -0500 (CDT) Date: Sat, 05 Apr 2008 16:30:00 -0000 From: Jerry DeLisle Subject: Re: [patch, fortran]PR25829 Add support for F2003 I/O features In-reply-to: <20080405113248.GA30275@physik.fu-berlin.de> To: Tobias Burnus Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Message-id: <1207409043.2963.17.camel@lenova.localdomain> MIME-version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-type: text/plain Content-transfer-encoding: 7bit References: <20080405113248.GA30275@physik.fu-berlin.de> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-04/txt/msg00452.txt.bz2 On Sat, 2008-04-05 at 13:32 +0200, Tobias Burnus wrote: > Hi Jerry, > > > The patch is getting too big so i do not want to add any more until we > > get this in trunk, > > With that said, I have attached the latest patch and 7 new test cases. > > OK for trunk. > > I think the patch is OK. > > I added some more items below, but they can be fixed later. > (a), (b) and (c) are relatively simply, (d) needs more effort. > And (e) can be postponed or included in the (a) to (c) patch. > Yes all of these of course. Most should be straight forward at this point. It takes some tedium to do. An example to watch out for is the sign status mechanism. There are two different enumerators being used. The original is embedded in the dtp structure. The other is unit_sign in io.h. The unit_sign is the way to go, however, if it is not ordered correctly, things break. (I will add that it took some time to figure that out) Fixing this is on my list. I plan to commit the patch after the following: 1) clean up ChangeLogs 2) Version the st_wait symbol 3) Cross test the libraries with 4.3 After the commit, I will start on the items identified by Tobias. Thanks for review and test case examples. Jerry