From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2250 invoked by alias); 7 Apr 2008 22:18:30 -0000 Received: (qmail 2234 invoked by uid 22791); 7 Apr 2008 22:18:30 -0000 X-Spam-Check-By: sourceware.org Received: from vms173001pub.verizon.net (HELO vms173001pub.verizon.net) (206.46.173.1) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 07 Apr 2008 22:18:10 +0000 Received: from [192.168.1.5] ([71.120.231.15]) by vms173001.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JYZ008UC79LQ991@vms173001.mailsrvcs.net>; Mon, 07 Apr 2008 17:17:46 -0500 (CDT) Date: Mon, 07 Apr 2008 22:38:00 -0000 From: Jerry DeLisle Subject: Re: [patch,fortran] F2003 Inquire features In-reply-to: <20080407211424.GA27487@physik.fu-berlin.de> To: Tobias Burnus Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Message-id: <1207606664.29096.5.camel@lenova.localdomain> MIME-version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-3.fc8) Content-type: text/plain Content-transfer-encoding: 7bit References: <20080407211424.GA27487@physik.fu-berlin.de> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-04/txt/msg00577.txt.bz2 On Mon, 2008-04-07 at 23:14 +0200, Tobias Burnus wrote: > > Attached is the final patch of this installment. > > Thanks for the patch! > > > Regression tested and NIST tested. I am still working up test cases to > > add. > > > > OK to commit? > > OK after fixing the issues mentioned below. > > Index: gcc/fortran/io.c: > | > | if (open->encoding->expr_type == EXPR_CONSTANT) > | { > | - static const char * encoding[] = { "UTF-8", "DEFAULT", NULL }; > | + static const char * encoding[] = { "DEFAULT", NULL }; > > Add a TODO: UTF-8 there. (In the library there is already such a TODO.) > > Done > Index: libgfortran/io/inquire.c: > + case ROUND_UNSPECIFIED: > + p = "UNSPECIFIED"; > + break; > > This is wrong. > Well not really wrong, but it is dead code. This is just translating the incoming specifier to the corresponding string. That specifier never happens since it is set to ROUND_PROCDEFINED elsewhere. So inquire actually returns "PROCESSOR_DEFINED" right now. I deleted the dead code. Patch committed. I am working some test cases now to be sutable for the testsuite. Thanks for reviews and comments. Jerry