[PATCH,testsuite] Mark builtin_return-1 test XFAIL on AVR target.

[PATCH,testsuite] Mark builtin_return-1 test XFAIL on AVR target.

[Andy H]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

Test gcc.dg/builtin-return-1.c  will fail for AVRtarget.

Default implementation of untyped return is a single register. Which for 
AVR is just a byte, not int as test expects.
So high byte may get overwritten before return.

I have marked as XFAIL until either test considers return value limit 
(unlikely and awkward) - or a complete untyped return is added for AVR.

Also added missing prototype for exit() to prevent warning.

Test on i686 and AVR target.

Ok for 4.4 mainline?



2008-06-17  Andy Hutchinson   <hutchinsonandy@aim.com>

  * gcc/testsuite/gcc.dg/builtin-return-1.c: Mark as xfail on AVR 
target. Add exit  prototype.



[-- Attachment #2: return.patch --]
[-- Type: text/plain, Size: 740 bytes --]

Index: gcc/testsuite/gcc.dg/builtin-return-1.c
===================================================================
--- gcc/testsuite/gcc.dg/builtin-return-1.c	(revision 136775)
+++ gcc/testsuite/gcc.dg/builtin-return-1.c	(working copy)
@@ -1,11 +1,12 @@
 /* PR middle-end/11151 */
 /* Originator: Andrew Church <gcczilla@achurch.org> */
 /* { dg-do run } */
-
+/* { dg-xfail-run-if "avr default untyped return is char register" { "avr-*-*" } { "*" } { "" } } */
 /* This used to fail on SPARC because the (undefined) return
    value of 'bar' was overwriting that of 'foo'.  */
 
 extern void abort(void);
+extern void exit(int);
 
 int foo(int n)
 {
@@ -29,6 +30,6 @@
 
   if (bar(1) != 2)
     abort();
-
+	exit(0);
   return 0;
 }

Re: [PATCH,testsuite] Mark builtin_return-1 test XFAIL on AVR target.

[Janis Johnson]

On Tue, 2008-06-17 at 21:53 -0400, Andy H wrote:
> Test gcc.dg/builtin-return-1.c  will fail for AVRtarget.
> 
> Default implementation of untyped return is a single register. Which for 
> AVR is just a byte, not int as test expects.
> So high byte may get overwritten before return.
> 
> I have marked as XFAIL until either test considers return value limit 
> (unlikely and awkward) - or a complete untyped return is added for AVR.
> 
> Also added missing prototype for exit() to prevent warning.
> 
> Test on i686 and AVR target.
> 
> Ok for 4.4 mainline?
> 
> 
> 
> 2008-06-17  Andy Hutchinson   <hutchinsonandy@aim.com>
> 
>   * gcc/testsuite/gcc.dg/builtin-return-1.c: Mark as xfail on AVR 
> target. Add exit  prototype.

An XFAIL must reference a problem report.  That's not true of all
of them in the testsuite, but should be so we can keep track of
them.  Please open a PR and reference it in the test.

Janis