public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Denys Vlasenko <dvlasenk@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Jakub Jelinek <jakub@redhat.com>, Zack Weinberg <zackw@panix.com>,
	        Ian Lance Taylor <iant@google.com>,
	        GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] gcc cannot deal with full /tmp
Date: Mon, 18 Aug 2008 13:25:00 -0000	[thread overview]
Message-ID: <1219062421.8911.20.camel@localhost.localdomain> (raw)
In-Reply-To: <jezlnattho.fsf@sykes.suse.de>

On Mon, 2008-08-18 at 14:09 +0200, Andreas Schwab wrote:
> >> > ELOOP is a good counter-example. "ln -s bogus /tmp/bogus" is not such
> >> > an implausible operation. Any user can do that.
> >> 
> >> Can you find a single OS which gives you ELOOP for O_EXCL creat?
> >
> > No.
> >
> > But I cannot find an OS which gives me EISDIR either,
> > thus the same argument works against EISDIR all the same.
> >
> > My argument is that it's better to proactively assume that there can be
> > some OSes which do it, or will do it in the future, and code around it
> > so that we won't need to revisit this issue.
> 
> If you can't create a file in /tmp for a reason other than `file exists'
> trying a different name is unlikely to succeed either, so in practice,
> EEXIST is the only interesting error.

Did you read the whole thread? Specifically, the below mail?
It's not *me* who said that we should check other errno's.

Moreover, at https://bugzilla.redhat.com/show_bug.cgi?id=203231
I *did* attach a patch which checks only for EEXIST.


On Fri, 2008-08-01 at 14:51 -0700, Zack Weinberg wrote:
On Fri, Aug 1, 2008 at 3:57 AM, Denys Vlasenko <dvlasenk@redhat.com>
wrote:
> [...]
> > My original approach was to reduce number of loops
> > instead of bailing out _immediately_ on errno != EEXIST.
> > I feared that otherwise I'll have to deal with
> > "obscure system XYZ throws weird errno at me" syndrome.
> >
> > This is it coming true.
> 
> I'm quite confident that EEXIST and EISDIR are the only two errno
> codes that should trigger looping.


--
vda


  reply	other threads:[~2008-08-18 12:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31 19:59 Zack Weinberg
2008-07-31 21:48 ` Ian Lance Taylor
2008-08-01 10:57   ` Denys Vlasenko
2008-08-01 21:51     ` Zack Weinberg
2008-08-04 11:03       ` Denys Vlasenko
2008-08-17  8:33         ` Zack Weinberg
2008-08-18 12:10           ` Denys Vlasenko
2008-08-18 12:29             ` Jakub Jelinek
2008-08-18 12:35               ` Denys Vlasenko
2008-08-18 13:24                 ` Andreas Schwab
2008-08-18 13:25                   ` Denys Vlasenko [this message]
2008-08-18 13:57                     ` Andreas Schwab
  -- strict thread matches above, loose matches on Subject: below --
2008-07-28 19:25 Denys Vlasenko
2008-07-28 20:12 ` Joseph S. Myers
2008-07-28 21:22   ` Aaron W. LaFramboise
2008-07-29 15:57 ` Ian Lance Taylor
2008-07-29 16:57   ` Jakub Jelinek
2008-07-30 14:17   ` Denys Vlasenko
2008-07-30 15:12     ` Ian Lance Taylor
2008-07-31 10:30       ` Jakub Jelinek
2008-07-31 20:15         ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219062421.8911.20.camel@localhost.localdomain \
    --to=dvlasenk@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iant@google.com \
    --cc=jakub@redhat.com \
    --cc=schwab@suse.de \
    --cc=zackw@panix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).