public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Janis Johnson <janis187@us.ibm.com>
To: Sebastian Pop <sebpop@gmail.com>
Cc: gcc-patches@gcc.gnu.org, "rajagopal, dwarak" <dwarak.rajagopal@amd.com>
Subject: Re: review of graphite testsuite patch
Date: Thu, 21 Aug 2008 20:47:00 -0000	[thread overview]
Message-ID: <1219350158.6859.10.camel@janis-laptop> (raw)
In-Reply-To: <cb9d34b20808211206t7b015b7cw4faad285ae1c08ed@mail.gmail.com>

On Thu, 2008-08-21 at 14:06 -0500, Sebastian Pop wrote:
> On Wed, Aug 20, 2008 at 4:40 PM, Janis Johnson <janis187@us.ibm.com> wrote:
> > This review of the testsuite changes for graphite is based on

> Attached is a patch that fixes the testsuite according to these
> comments.  Committed to graphite-branch.

That looks good, merge the tests to mainline when appropriate.

> > Almost all tests use the same options.  Within the graphite.exp files
> > in the test suites you could set GRAPHITE_FLAGS to the options that are
> > used for most tests and pass that, instead of DEFAULT_CFLAGS, to
> > dg-runtest.  Those could be overridden in individual tests.  Again,
> > this is just a suggestion.
> 
> This is not yet fixed.

As I said, it's just a suggestion, they're fine as they are.

> > Test gfortran.dg/graphite/scop-1.f doesn't do any checking, what is
> > its purpose?
> >
> scop-1.f was a bug that we reduced.  We test it for compilation only,
> but we can also write a test for the number of SCoPs it contains.

If you don't add the test to check the dump file, add a comment
explaining that the test caused a compilation failure during
development.

Janis

  reply	other threads:[~2008-08-21 20:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20 22:24 Janis Johnson
2008-08-21 19:19 ` Sebastian Pop
2008-08-21 20:47   ` Janis Johnson [this message]
2008-08-21 21:47     ` Sebastian Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219350158.6859.10.camel@janis-laptop \
    --to=janis187@us.ibm.com \
    --cc=dwarak.rajagopal@amd.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=sebpop@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).