From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id C5678385B524 for ; Mon, 7 Aug 2023 10:05:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C5678385B524 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 377A2d1O031667; Mon, 7 Aug 2023 10:05:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=LA8cNSMxaYWedypzVQ3oZBPNoU7X62+nZWNvnbJ1/p0=; b=LNHGVPm+t+yCo4UsZiGaHnOA7J8lEcafv6LS4FatTR4UWy1cDgLXbCZJBy2gXZrah6W0 YKfJqbbXca2rGAJzzIW3JBBaCRJa/SKKjPDjs1sy4CHL7CLaFU08KohBuebiAXoYLcDS ASv8SYF2YFTbY/sj7TAhc5juMqZ4W+v0SuEWIGt71+bQdfh9PQND0USysDqkIB6CLmAh fIcyEbrcGqJRs10u/uj2mmSicHjqbIK958uBemQ2ghqNsfIjK9KA3aeSdtyHeP9QiVEy eBPJFTg5/gVjxc3YhC0TcnbeM+ps0m3zppmkmling7vPjco+gST4VA8XsPWnYym1xtgJ Bw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3saxgvg552-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Aug 2023 10:05:58 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 377A2ecL031909; Mon, 7 Aug 2023 10:05:57 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3saxgvg53m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Aug 2023 10:05:57 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3779qPei007560; Mon, 7 Aug 2023 10:05:55 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3sa14xvbj5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Aug 2023 10:05:55 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 377A5q7I39125702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Aug 2023 10:05:52 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 94BA220040; Mon, 7 Aug 2023 10:05:49 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A4CD32004F; Mon, 7 Aug 2023 10:05:47 +0000 (GMT) Received: from [9.197.227.212] (unknown [9.197.227.212]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 7 Aug 2023 10:05:47 +0000 (GMT) Message-ID: <12207532-fe3a-b433-43ef-7e375939467c@linux.ibm.com> Date: Mon, 7 Aug 2023 18:05:46 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: PING^4 [PATCH 0/9] rs6000: Rework rs6000_emit_vector_compare Content-Language: en-US To: gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, bergner@linux.ibm.com, meissner@linux.ibm.com References: <20221124091557.514727-1-linkw@linux.ibm.com> <59fbb646-c855-c4cd-10f9-40996f4e9720@linux.ibm.com> <73b2a139-0664-6dda-13c1-622d51745b30@linux.ibm.com> <804f6ee1-eb62-ea72-648e-1ac9036d0606@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <804f6ee1-eb62-ea72-648e-1ac9036d0606@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: CCs9R-v51T1K8wLg7Isf1_uJFBhdZji8 X-Proofpoint-GUID: X2WvYxnlSUq5115J_9dnkqKfQrqh4aAi Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-07_09,2023-08-03_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308070093 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Gentle ping this series: https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607146.html BR, Kewen >>> on 2022/11/24 17:15, Kewen Lin wrote: >>>> Hi, >>>> >>>> Following Segher's suggestion, this patch series is to rework >>>> function rs6000_emit_vector_compare for vector float and int >>>> in multiple steps, it's based on the previous attempts [1][2]. >>>> As mentioned in [1], the need to rework this for float is to >>>> make a centralized place for vector float comparison handlings >>>> instead of supporting with swapping ops and reversing code etc. >>>> dispersedly. It's also for a subsequent patch to handle >>>> comparison operators with or without trapping math (PR105480). >>>> With the handling on vector float reworked, we can further make >>>> the handling on vector int simplified as shown. >>>> >>>> For Segher's concern about whether this rework causes any >>>> assembly change, I constructed two testcases for vector float[3] >>>> and int[4] respectively before, it showed the most are fine >>>> excepting for the difference on LE and UNGT, it's demonstrated >>>> as improvement since it uses GE instead of GT ior EQ. The >>>> associated test case in patch 3/9 is a good example. >>>> >>>> Besides, w/ and w/o the whole patch series, I built the whole >>>> SPEC2017 at options -O3 and -Ofast separately, checked the >>>> differences on object assembly. The result showed that the >>>> most are unchanged, except for: >>>> >>>> * at -O3, 521.wrf_r has 9 object files and 526.blender_r has >>>> 9 object files with differences. >>>> >>>> * at -Ofast, 521.wrf_r has 12 object files, 526.blender_r has >>>> one and 527.cam4_r has 4 object files with differences. >>>> >>>> By looking into these differences, all significant differences >>>> are caused by the known improvement mentined above transforming >>>> GT ior EQ to GE, which can also affect unrolling decision due >>>> to insn count. Some other trivial differences are branch >>>> target offset difference, nop difference for alignment, vsx >>>> register number differences etc. >>>> >>>> I also evaluated the runtime performance for these changed >>>> benchmarks, the result is neutral. >>>> >>>> These patches are bootstrapped and regress-tested >>>> incrementally on powerpc64-linux-gnu P7 & P8, and >>>> powerpc64le-linux-gnu P9 & P10. >>>> >>>> Is it ok for trunk? >>>> >>>> BR, >>>> Kewen >>>> ----- >>>> [1] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606375.html >>>> [2] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606376.html >>>> [3] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606504.html >>>> [4] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606506.html >>>> >>>> Kewen Lin (9): >>>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p1 >>>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p2 >>>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p3 >>>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p4 >>>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p1 >>>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p2 >>>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p3 >>>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p4 >>>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p5 >>>> >>>> gcc/config/rs6000/rs6000.cc | 180 ++++++-------------- >>>> gcc/testsuite/gcc.target/powerpc/vcond-fp.c | 25 +++ >>>> 2 files changed, 74 insertions(+), 131 deletions(-) >>>> create mode 100644 gcc/testsuite/gcc.target/powerpc/vcond-fp.c >>>>