From: Steve Ellcey <sje@cup.hp.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch, omp] Patch to omp-low.c to fix failures on IA64 HP-UX
Date: Fri, 31 Oct 2008 18:06:00 -0000 [thread overview]
Message-ID: <1225471655.11006.6.camel@hpsje.cup.hp.com> (raw)
In-Reply-To: <20081031121602.GW14706@tyan-ft48-01.lab.bos.redhat.com>
On Fri, 2008-10-31 at 13:16 +0100, Jakub Jelinek wrote:
> Can you test it on HPUX?
>
> --- gcc/omp-low.c.jj 2008-09-30 16:57:11.000000000 +0200
> +++ gcc/omp-low.c 2008-10-31 13:03:00.000000000 +0100
> @@ -3681,8 +3681,20 @@ expand_omp_for_generic (struct omp_regio
> t4 = build_fold_addr_expr (iend0);
> t3 = build_fold_addr_expr (istart0);
> t2 = fold_convert (fd->iter_type, fd->loop.step);
> - t1 = fold_convert (fd->iter_type, fd->loop.n2);
> - t0 = fold_convert (fd->iter_type, fd->loop.n1);
> + if (POINTER_TYPE_P (type)
> + && TYPE_PRECISION (type) != TYPE_PRECISION (fd->iter_type))
> + {
> + /* Avoid casting pointers to integer of a different size. */
> + tree itype
> + = lang_hooks.types.type_for_size (TYPE_PRECISION (itype), 0);
I am assuming that should be "TYPE_PRECISION (type)", not
"TYPE_PRECISION (itype)" in the type_for_size call. I will test the
patch with that change.
Steve Ellcey
sje@cup.hp.com
prev parent reply other threads:[~2008-10-31 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 0:38 Steve Ellcey
2008-10-31 0:49 ` Richard Guenther
2008-10-31 13:08 ` Jakub Jelinek
2008-10-31 18:06 ` Steve Ellcey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225471655.11006.6.camel@hpsje.cup.hp.com \
--to=sje@cup.hp.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).