* [PATCH] Fix g++.dg/abi/key2.C testcase on darwin (PR testsuite/37241)
@ 2008-11-03 20:30 Jakub Jelinek
2008-11-03 20:55 ` Janis Johnson
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2008-11-03 20:30 UTC (permalink / raw)
To: Janis Johnson; +Cc: gcc-patches
Hi!
This testcase fails since -O0 went to -funit-at-a-time
-fno-toplevel-reorder, as the _ZT{V,S,I}* objects are now emitted
in different order and __ZT{V,I}* which are in the same section
now use just one .section directive instead of 2, when __ZTS* was
emitted in between them.
Tested by Dominique, ok for trunk?
2008-11-03 Jakub Jelinek <jakub@redhat.com>
PR testsuite/37241
* g++.dg/abi/key2.C: Adjust regexps to allow __ZTV1f and __ZTI1f
sharing one .section directive.
--- gcc/testsuite/g++.dg/abi/key2.C.jj 2008-09-05 12:55:05.000000000 +0200
+++ gcc/testsuite/g++.dg/abi/key2.C 2008-11-03 12:53:16.000000000 +0100
@@ -2,9 +2,9 @@
// PR darwin/25908
// { dg-do compile { target *-*-darwin* } }
-// { dg-final { scan-assembler ".globl __ZTV1f\\n .weak_definition __ZTV1f\\n .section __DATA,__const_coal,coalesced" } }
+// { dg-final { scan-assembler ".globl __ZTV1f\\n .weak_definition __ZTV1f(\\n .section __DATA,__const_coal,coalesced)?\\n .align" } }
// { dg-final { scan-assembler ".globl __ZTS1f\\n .weak_definition __ZTS1f\\n .section __TEXT,__const_coal,coalesced" } }
-// { dg-final { scan-assembler ".globl __ZTI1f\\n .weak_definition __ZTI1f\\n .section __DATA,__const_coal,coalesced" } }
+// { dg-final { scan-assembler ".globl __ZTI1f\\n .weak_definition __ZTI1f(\\n .section __DATA,__const_coal,coalesced)?\\n .align" } }
class f
{
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix g++.dg/abi/key2.C testcase on darwin (PR testsuite/37241)
2008-11-03 20:30 [PATCH] Fix g++.dg/abi/key2.C testcase on darwin (PR testsuite/37241) Jakub Jelinek
@ 2008-11-03 20:55 ` Janis Johnson
0 siblings, 0 replies; 2+ messages in thread
From: Janis Johnson @ 2008-11-03 20:55 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches
On Mon, 2008-11-03 at 21:29 +0100, Jakub Jelinek wrote:
> Hi!
>
> This testcase fails since -O0 went to -funit-at-a-time
> -fno-toplevel-reorder, as the _ZT{V,S,I}* objects are now emitted
> in different order and __ZT{V,I}* which are in the same section
> now use just one .section directive instead of 2, when __ZTS* was
> emitted in between them.
> Tested by Dominique, ok for trunk?
OK.
Janis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-03 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-03 20:30 [PATCH] Fix g++.dg/abi/key2.C testcase on darwin (PR testsuite/37241) Jakub Jelinek
2008-11-03 20:55 ` Janis Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).