* [PATCH] PR37202 skip gcc.dg/visibility-1[4-9].c on *-apple-darwin*
@ 2008-11-11 15:35 Jack Howarth
2008-11-11 17:02 ` Jack Howarth
2008-11-11 22:34 ` Janis Johnson
0 siblings, 2 replies; 3+ messages in thread
From: Jack Howarth @ 2008-11-11 15:35 UTC (permalink / raw)
To: gcc-patches
The attached patch skips the gcc.dg/visibility-1[4-9].c testcases
on *-apple-darwin* as recommended in comment 4 of PR37202. Tested
on i686-apple-darwin9. Okay for gcc trunk?
Jack
2008-11-11 Jack Howarth <howarth@bromo.med.uc.edu>
PR testsuite/37202
* gcc.dg/visibility-14.c: Skip on *-apple-darwin*.
* gcc.dg/visibility-15.c: Same.
* gcc.dg/visibility-16.c: Same.
* gcc.dg/visibility-17.c: Same.
* gcc.dg/visibility-18.c: Same.
* gcc.dg/visibility-19.c: Same.
Index: gcc/testsuite/gcc.dg/visibility-15.c
===================================================================
--- gcc/testsuite/gcc.dg/visibility-15.c (revision 141763)
+++ gcc/testsuite/gcc.dg/visibility-15.c (working copy)
@@ -1,5 +1,6 @@
/* Test that accessed external functions are marked. */
/* { dg-do compile } */
+/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
/* { dg-require-visibility "" } */
/* { dg-final { scan-hidden "foo" } } */
Index: gcc/testsuite/gcc.dg/visibility-17.c
===================================================================
--- gcc/testsuite/gcc.dg/visibility-17.c (revision 141763)
+++ gcc/testsuite/gcc.dg/visibility-17.c (working copy)
@@ -1,5 +1,6 @@
/* Test that external variable whose address is taken are marked. */
/* { dg-do compile } */
+/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
/* { dg-require-visibility "" } */
/* { dg-final { scan-hidden "foo" } } */
Index: gcc/testsuite/gcc.dg/visibility-19.c
===================================================================
--- gcc/testsuite/gcc.dg/visibility-19.c (revision 141763)
+++ gcc/testsuite/gcc.dg/visibility-19.c (working copy)
@@ -1,5 +1,6 @@
/* Test that accessed external functions are marked. */
/* { dg-do compile } */
+/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
/* { dg-require-visibility "" } */
/* { dg-final { scan-hidden "foo" } } */
Index: gcc/testsuite/gcc.dg/visibility-14.c
===================================================================
--- gcc/testsuite/gcc.dg/visibility-14.c (revision 141763)
+++ gcc/testsuite/gcc.dg/visibility-14.c (working copy)
@@ -1,5 +1,6 @@
/* Test that called external functions are marked. */
/* { dg-do compile } */
+/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
/* { dg-require-visibility "" } */
/* { dg-final { scan-hidden "foo" } } */
Index: gcc/testsuite/gcc.dg/visibility-16.c
===================================================================
--- gcc/testsuite/gcc.dg/visibility-16.c (revision 141763)
+++ gcc/testsuite/gcc.dg/visibility-16.c (working copy)
@@ -1,5 +1,6 @@
/* Test that accessed external variables are marked. */
/* { dg-do compile } */
+/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
/* { dg-require-visibility "" } */
/* { dg-final { scan-hidden "foo" } } */
Index: gcc/testsuite/gcc.dg/visibility-18.c
===================================================================
--- gcc/testsuite/gcc.dg/visibility-18.c (revision 141763)
+++ gcc/testsuite/gcc.dg/visibility-18.c (working copy)
@@ -1,5 +1,6 @@
/* Test that external variable whose address is taken are marked. */
/* { dg-do compile } */
+/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
/* { dg-require-visibility "" } */
/* { dg-final { scan-hidden "foo" } } */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PR37202 skip gcc.dg/visibility-1[4-9].c on *-apple-darwin*
2008-11-11 15:35 [PATCH] PR37202 skip gcc.dg/visibility-1[4-9].c on *-apple-darwin* Jack Howarth
@ 2008-11-11 17:02 ` Jack Howarth
2008-11-11 22:34 ` Janis Johnson
1 sibling, 0 replies; 3+ messages in thread
From: Jack Howarth @ 2008-11-11 17:02 UTC (permalink / raw)
To: gcc-patches
On Tue, Nov 11, 2008 at 10:31:37AM -0500, Jack Howarth wrote:
> The attached patch skips the gcc.dg/visibility-1[4-9].c testcases
> on *-apple-darwin* as recommended in comment 4 of PR37202. Tested
> on i686-apple-darwin9. Okay for gcc trunk?
> Jack
>
> 2008-11-11 Jack Howarth <howarth@bromo.med.uc.edu>
>
> PR testsuite/37202
> * gcc.dg/visibility-14.c: Skip on *-apple-darwin*.
> * gcc.dg/visibility-15.c: Same.
> * gcc.dg/visibility-16.c: Same.
> * gcc.dg/visibility-17.c: Same.
> * gcc.dg/visibility-18.c: Same.
> * gcc.dg/visibility-19.c: Same.
>
> Index: gcc/testsuite/gcc.dg/visibility-15.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-15.c (revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-15.c (working copy)
> @@ -1,5 +1,6 @@
> /* Test that accessed external functions are marked. */
> /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
> /* { dg-require-visibility "" } */
> /* { dg-final { scan-hidden "foo" } } */
>
> Index: gcc/testsuite/gcc.dg/visibility-17.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-17.c (revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-17.c (working copy)
> @@ -1,5 +1,6 @@
> /* Test that external variable whose address is taken are marked. */
> /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
> /* { dg-require-visibility "" } */
> /* { dg-final { scan-hidden "foo" } } */
>
> Index: gcc/testsuite/gcc.dg/visibility-19.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-19.c (revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-19.c (working copy)
> @@ -1,5 +1,6 @@
> /* Test that accessed external functions are marked. */
> /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
> /* { dg-require-visibility "" } */
> /* { dg-final { scan-hidden "foo" } } */
>
> Index: gcc/testsuite/gcc.dg/visibility-14.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-14.c (revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-14.c (working copy)
> @@ -1,5 +1,6 @@
> /* Test that called external functions are marked. */
> /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
> /* { dg-require-visibility "" } */
> /* { dg-final { scan-hidden "foo" } } */
>
> Index: gcc/testsuite/gcc.dg/visibility-16.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-16.c (revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-16.c (working copy)
> @@ -1,5 +1,6 @@
> /* Test that accessed external variables are marked. */
> /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
> /* { dg-require-visibility "" } */
> /* { dg-final { scan-hidden "foo" } } */
>
> Index: gcc/testsuite/gcc.dg/visibility-18.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/visibility-18.c (revision 141763)
> +++ gcc/testsuite/gcc.dg/visibility-18.c (working copy)
> @@ -1,5 +1,6 @@
> /* Test that external variable whose address is taken are marked. */
> /* { dg-do compile } */
> +/* { dg-skip-if "" { *-*-darwin* } { "*" } { "" } } */
> /* { dg-require-visibility "" } */
> /* { dg-final { scan-hidden "foo" } } */
>
A minor correction to the ChangeLog entry. It should really read...
2008-11-11 Jack Howarth <howarth@bromo.med.uc.edu>
PR testsuite/37202
* gcc.dg/visibility-14.c: Skip on *-*-darwin*.
* gcc.dg/visibility-15.c: Same.
* gcc.dg/visibility-16.c: Same.
* gcc.dg/visibility-17.c: Same.
* gcc.dg/visibility-18.c: Same.
* gcc.dg/visibility-19.c: Same.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PR37202 skip gcc.dg/visibility-1[4-9].c on *-apple-darwin*
2008-11-11 15:35 [PATCH] PR37202 skip gcc.dg/visibility-1[4-9].c on *-apple-darwin* Jack Howarth
2008-11-11 17:02 ` Jack Howarth
@ 2008-11-11 22:34 ` Janis Johnson
1 sibling, 0 replies; 3+ messages in thread
From: Janis Johnson @ 2008-11-11 22:34 UTC (permalink / raw)
To: Jack Howarth; +Cc: gcc-patches
On Tue, 2008-11-11 at 10:31 -0500, Jack Howarth wrote:
> The attached patch skips the gcc.dg/visibility-1[4-9].c testcases
> on *-apple-darwin* as recommended in comment 4 of PR37202. Tested
> on i686-apple-darwin9. Okay for gcc trunk?
OK, with the ChangeLog change from your follow-up mail.
This should probably be approved by a Darwin maintainer but
they're not following patches much these days.
Janis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-11 22:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-11 15:35 [PATCH] PR37202 skip gcc.dg/visibility-1[4-9].c on *-apple-darwin* Jack Howarth
2008-11-11 17:02 ` Jack Howarth
2008-11-11 22:34 ` Janis Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).