From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id 1B43A3858D38 for ; Fri, 23 Sep 2022 18:07:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1B43A3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pj1-x102d.google.com with SMTP id s90-20020a17090a2f6300b00203a685a1aaso928315pjd.1 for ; Fri, 23 Sep 2022 11:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=2zGAIWDW2bgGMnkRyUP+5ODow/jrUi84Rp2tR/7UCho=; b=gXaLFypT+F3nrGXFcb95TGtIkRf0VKhkGoiFp3TMy6WqG5k4q8xW24Y3aYBu640Cxl y2NUxx6rMRd8Qfxj2tYVbyUejk7WzPcU4wsVJ1gHWqAXfoW7bRX8eJZqdj4WkV0tjJpf CQqTgdzLScr+ZRy83MrP+4h4qiRxJRDFZvjFNcraZM5LnTBi+Ua14+nwTYhkwDwn/o0P g1R/7lZ3sgQxym2jB82dJvnqfsvb7xm1YX7X2tF/vAB737gFRv4ZZevlPJMFD2uyUF4I iIJyMpTWVFCC5D5IqUtoDeiCasOtzmqN+WER/vkYFhuGdYs9JzKesNp6HeQUJuNy+OWC aPMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=2zGAIWDW2bgGMnkRyUP+5ODow/jrUi84Rp2tR/7UCho=; b=32aARUXn8Tm0EzEuM9iUQtttdW47XQy11A5C3Vl3GHAEs62/8q7Q7pI036yxImpF2i KGCZ0jC7ZF8mIJTjqWX4xpiTQEavTn2qofRytVkAvIwvgnYuf3KRhEu7m/5QLvGLNuCt cR6GLfQy3AlXTORtn3ymC+MCzhggFYjfDw4yt7z5n1VQllYxN+2/El2DpSvxXRmE69y+ qr00hpuC6qYDdZBUI19WtwrFvOfR3zvvFPAJ1u1ufnJfwVpRYOU8Pr7ik8trHSUVHDti YcM8bTsiB2BEQvn7AzFcjctPg5ke26Ipi6uZLWPTp7XTekoSK376IFTqdQ3j1xhcmJtV qGNg== X-Gm-Message-State: ACrzQf3p8EjpArrmlicpgTStbSMS3MiQEL4neWOT9h4KrBLEwEM3Hwo0 MRTwmROkVc/MjVT0MQ3GnZDhiIiUByABGA== X-Google-Smtp-Source: AMsMyM7HSucn5jM4rkh3JR7OUtoK1uo89lR1VSL79ZHLLhh/3ij3IHabTYZOejLfwhaNeNf+ededzg== X-Received: by 2002:a17:90b:4c43:b0:203:1ba4:f29a with SMTP id np3-20020a17090b4c4300b002031ba4f29amr11204404pjb.76.1663956443957; Fri, 23 Sep 2022 11:07:23 -0700 (PDT) Received: from [192.168.50.116] (c-24-4-73-83.hsd1.ca.comcast.net. [24.4.73.83]) by smtp.gmail.com with ESMTPSA id l14-20020a17090a408e00b001fd8316db51sm1877753pjg.7.2022.09.23.11.07.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 11:07:23 -0700 (PDT) Message-ID: <1236ab56-3823-124b-1c91-63b1dbc94aa7@rivosinc.com> Date: Fri, 23 Sep 2022 11:07:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] RISC-V: remove deprecate pic code model macro Content-Language: en-US To: gcc-patches@gcc.gnu.org Cc: collison@rivosinc.com, gnu-toolchain@rivosinc.com, kito.cheng@gmail.com, Philipp Tomsich References: <8735d9a3qr.fsf@igel.home> <20220902210533.373663-1-vineetg@rivosinc.com> From: Vineet Gupta In-Reply-To: <20220902210533.373663-1-vineetg@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/2/22 14:05, Vineet Gupta wrote: > Came across this deprecated symbol when looking around for > -mexplicit-relocs handling in code > > Signed-off-by: Vineet Gupta No rush but looks like this got lost in the bigger thread about LOAD_ADDRESS_MACRO. Thx, -Vineet > --- > gcc/config/riscv/riscv-c.cc | 5 ----- > gcc/testsuite/gcc.target/riscv/predef-1.c | 3 --- > gcc/testsuite/gcc.target/riscv/predef-2.c | 3 --- > gcc/testsuite/gcc.target/riscv/predef-3.c | 3 --- > gcc/testsuite/gcc.target/riscv/predef-4.c | 3 --- > gcc/testsuite/gcc.target/riscv/predef-5.c | 3 --- > gcc/testsuite/gcc.target/riscv/predef-6.c | 3 --- > gcc/testsuite/gcc.target/riscv/predef-7.c | 3 --- > gcc/testsuite/gcc.target/riscv/predef-8.c | 3 --- > 9 files changed, 29 deletions(-) > > diff --git a/gcc/config/riscv/riscv-c.cc b/gcc/config/riscv/riscv-c.cc > index eb7ef09297e9..8d55ad598a9c 100644 > --- a/gcc/config/riscv/riscv-c.cc > +++ b/gcc/config/riscv/riscv-c.cc > @@ -93,11 +93,6 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile) > break; > > case CM_PIC: > - /* __riscv_cmodel_pic is deprecated, and will removed in next GCC release. > - see https://github.com/riscv/riscv-c-api-doc/pull/11 */ > - builtin_define ("__riscv_cmodel_pic"); > - /* FALLTHROUGH. */ > - > case CM_MEDANY: > builtin_define ("__riscv_cmodel_medany"); > break; > diff --git a/gcc/testsuite/gcc.target/riscv/predef-1.c b/gcc/testsuite/gcc.target/riscv/predef-1.c > index 2e57ce6b3954..9dddc1849635 100644 > --- a/gcc/testsuite/gcc.target/riscv/predef-1.c > +++ b/gcc/testsuite/gcc.target/riscv/predef-1.c > @@ -57,9 +57,6 @@ int main () { > #endif > #if defined(__riscv_cmodel_medany) > #error "__riscv_cmodel_medlow" > -#endif > -#if defined(__riscv_cmodel_pic) > -#error "__riscv_cmodel_medlow" > #endif > > return 0; > diff --git a/gcc/testsuite/gcc.target/riscv/predef-2.c b/gcc/testsuite/gcc.target/riscv/predef-2.c > index c85b3c9fd32a..755fe4ef7d8a 100644 > --- a/gcc/testsuite/gcc.target/riscv/predef-2.c > +++ b/gcc/testsuite/gcc.target/riscv/predef-2.c > @@ -57,9 +57,6 @@ int main () { > #endif > #if !defined(__riscv_cmodel_medany) > #error "__riscv_cmodel_medlow" > -#endif > -#if defined(__riscv_cmodel_pic) > -#error "__riscv_cmodel_medlow" > #endif > > return 0; > diff --git a/gcc/testsuite/gcc.target/riscv/predef-3.c b/gcc/testsuite/gcc.target/riscv/predef-3.c > index 82a89d415809..513645351c09 100644 > --- a/gcc/testsuite/gcc.target/riscv/predef-3.c > +++ b/gcc/testsuite/gcc.target/riscv/predef-3.c > @@ -57,9 +57,6 @@ int main () { > #endif > #if !defined(__riscv_cmodel_medany) > #error "__riscv_cmodel_medany" > -#endif > -#if !defined(__riscv_cmodel_pic) > -#error "__riscv_cmodel_pic" > #endif > > return 0; > diff --git a/gcc/testsuite/gcc.target/riscv/predef-4.c b/gcc/testsuite/gcc.target/riscv/predef-4.c > index 5868d39eb67a..76b6feec6b6f 100644 > --- a/gcc/testsuite/gcc.target/riscv/predef-4.c > +++ b/gcc/testsuite/gcc.target/riscv/predef-4.c > @@ -57,9 +57,6 @@ int main () { > #endif > #if defined(__riscv_cmodel_medany) > #error "__riscv_cmodel_medlow" > -#endif > -#if defined(__riscv_cmodel_pic) > -#error "__riscv_cmodel_medlow" > #endif > > return 0; > diff --git a/gcc/testsuite/gcc.target/riscv/predef-5.c b/gcc/testsuite/gcc.target/riscv/predef-5.c > index 4b2bd3835061..54a51508afbd 100644 > --- a/gcc/testsuite/gcc.target/riscv/predef-5.c > +++ b/gcc/testsuite/gcc.target/riscv/predef-5.c > @@ -57,9 +57,6 @@ int main () { > #endif > #if !defined(__riscv_cmodel_medany) > #error "__riscv_cmodel_medlow" > -#endif > -#if defined(__riscv_cmodel_pic) > -#error "__riscv_cmodel_medlow" > #endif > > return 0; > diff --git a/gcc/testsuite/gcc.target/riscv/predef-6.c b/gcc/testsuite/gcc.target/riscv/predef-6.c > index 8e5ea366bd5e..f61709f7bf32 100644 > --- a/gcc/testsuite/gcc.target/riscv/predef-6.c > +++ b/gcc/testsuite/gcc.target/riscv/predef-6.c > @@ -57,9 +57,6 @@ int main () { > #endif > #if !defined(__riscv_cmodel_medany) > #error "__riscv_cmodel_medany" > -#endif > -#if !defined(__riscv_cmodel_pic) > -#error "__riscv_cmodel_medpic" > #endif > > return 0; > diff --git a/gcc/testsuite/gcc.target/riscv/predef-7.c b/gcc/testsuite/gcc.target/riscv/predef-7.c > index 0bde299aef1a..41217554c4db 100644 > --- a/gcc/testsuite/gcc.target/riscv/predef-7.c > +++ b/gcc/testsuite/gcc.target/riscv/predef-7.c > @@ -57,9 +57,6 @@ int main () { > #endif > #if defined(__riscv_cmodel_medany) > #error "__riscv_cmodel_medlow" > -#endif > -#if defined(__riscv_cmodel_pic) > -#error "__riscv_cmodel_medlow" > #endif > > return 0; > diff --git a/gcc/testsuite/gcc.target/riscv/predef-8.c b/gcc/testsuite/gcc.target/riscv/predef-8.c > index 18aa591a6039..982056a53438 100644 > --- a/gcc/testsuite/gcc.target/riscv/predef-8.c > +++ b/gcc/testsuite/gcc.target/riscv/predef-8.c > @@ -57,9 +57,6 @@ int main () { > #endif > #if !defined(__riscv_cmodel_medany) > #error "__riscv_cmodel_medlow" > -#endif > -#if defined(__riscv_cmodel_pic) > -#error "__riscv_cmodel_medlow" > #endif > > return 0;