From: Janis Johnson <janis187@us.ibm.com>
To: Richard Sandiford <rdsandiford@googlemail.com>
Cc: David Edelsohn <dje.gcc@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [8/8] Tidy up testsuite handling of LD_LIBRARY_PATH (needs testsuite maintainer)
Date: Thu, 02 Jul 2009 21:21:00 -0000 [thread overview]
Message-ID: <1246565957.5968.1.camel@janis-laptop> (raw)
In-Reply-To: <87iqiaj2nh.fsf@talisman.home>
On Thu, 2009-07-02 at 20:38 +0100, Richard Sandiford wrote:
> I just wanted to say a public "sorry" for all the fallout from this patch.
> Something obviosly went wrong with my testing.
Testsuite infrastructure cleanups usually break something somewhere,
but thanks for handling it quickly.
> David Edelsohn <dje.gcc@gmail.com> writes:
> > The appended patch fixes libgomp for me. I do not know if there is a
> > better / cleaner way. I tried setting TARGET_OPTIONS to -pthread for
> > target AIX, but that did not seem to affect the multilib directory
> > choice.
>
> libgomp stores various libgomp-specific options in a variable called
> ALWAYS_CFLAGS. These options are then used in every compilation test.
> The problem is that the same options aren't included when running
> "$cc --print-multi-lib", so the compiler isn't aware that
> we're using -fopenmp, and thus need pthreads.
>
> The patch below "fixes" this. I sent it to David privately because the
> AIX machine I use is down at the moment, and he confirms it fixes the
> problem (thanks!). OK to install?
OK.
Janis
next prev parent reply other threads:[~2009-07-02 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 14:41 David Edelsohn
2009-07-02 15:56 ` David Edelsohn
2009-07-02 19:44 ` Richard Sandiford
2009-07-02 21:21 ` Janis Johnson [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-02 12:03 [0/8] AIX cross toolchains Richard Sandiford
2009-06-02 12:33 ` [8/8] Tidy up testsuite handling of LD_LIBRARY_PATH (needs testsuite maintainer) Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246565957.5968.1.camel@janis-laptop \
--to=janis187@us.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).