From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30280 invoked by alias); 14 Oct 2009 14:33:20 -0000 Received: (qmail 30261 invoked by uid 22791); 14 Oct 2009 14:33:18 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (193.131.176.58) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Oct 2009 14:33:13 +0000 Received: from cam-owa2.Emea.Arm.com (cam-owa2.emea.arm.com [10.1.105.18]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id n9EEX9eI023971; Wed, 14 Oct 2009 15:33:09 +0100 (BST) Received: from [10.1.129.129] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 14 Oct 2009 15:33:09 +0100 Subject: Re: [ping] Re: [patch] PR40134, use a linker script on arm-linux to link with -lgcc_s -lgcc From: Richard Earnshaw To: Andrew Haley Cc: Matthias Klose , Jakub Jelinek , Alexandre Oliva , Nathan Froyd , GCC Patches , Paolo Carlini , GCJ-patches In-Reply-To: <4ABB4C9B.3070200@redhat.com> References: <4A530F5C.4040500@ubuntu.com> <20090707091425.GB4462@tyan-ft48-01.lab.bos.redhat.com> <4A5B32BB.5010308@ubuntu.com> <20090909112436.GV14664@tyan-ft48-01.lab.bos.redhat.com> <4AAA8510.8060906@ubuntu.com> <4AB8C07D.3010807@ubuntu.com> <4AB8F3C2.60909@redhat.com> <4ABB2CB3.8090800@ubuntu.com> <4ABB30DE.6050502@redhat.com> <4ABB3BE6.4060800@ubuntu.com> <4ABB4C9B.3070200@redhat.com> Content-Type: text/plain Date: Wed, 14 Oct 2009 15:15:00 -0000 Message-Id: <1255530788.4842.33.camel@e200601-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg00911.txt.bz2 On Thu, 2009-09-24 at 11:40 +0100, Andrew Haley wrote: > Matthias Klose wrote: > > On 24.09.2009 10:42, Andrew Haley wrote: > >> Matthias Klose wrote: > >>> On 22.09.2009 17:56, Andrew Haley wrote: > >>>> Matthias Klose wrote: > >>>>> On 11.09.2009 19:12, Matthias Klose wrote: > >>>> > >>>>>> Applied and checked the attach patch on top of your patch, ran the > >>>>>> testsuite without regressions (applied the patch for pr40133 from > >>>>>> Paolo > >>>>>> for the same test run as well). > >>>>>> > >>>>>> Matthias > >>>>> > >>>>> updated the patch to only for arm*-*-linux-*eabi; test results at > >>>>> http://gcc.gnu.org/ml/gcc-testresults/2009-09/msg02000.html > >>>>> > >>>>> Ok for the trunk? > >>>> > >>>> I'm not at all happy that backtraces are failing now on Java, but I > >>>> guess your > >>>> patch didn't cause that. OK by me. > >>> > >>> Without this patch, the build of libjava fails on arm*-*-linux-*eabi: > >>> > >>> /usr/bin/ld: .libs/jv-convert: hidden symbol `__sync_synchronize' in > >>> /root/gcc/newgccsnapshot/gcc-snapshot-20090919/build/./gcc/libgcc.a(linux-atomic.o) > >>> > >>> is referenced by DSO > >>> /usr/bin/ld: final link failed: Nonrepresentable section on output > >>> collect2: ld returned 1 exit status > >>> make[5]: *** [jv-convert] Error 1 > >>> > >>> Full buildlog at http://people.debian.org/~doko/tmp/snapshot.log.bz2 > >>> > >>> The reason for this is not linking the shared libgcj with -lgcc. > >> > >> I find this extremely surprising. LDFLAGS are explicitly set to do > >> that when building libgcc. I did this myself, and I'm pretty sure that > >> it works. > >> > >> svn diff -r150701:150702 > > > > The setting of LDFLAGS to "-Wl,-lgcc" (working around libtool > > assumptions) in the Makefile gets overwritten to the empty value when > > called by the toplevel make, so this has no effect. The intent to do > > this with a linker script was to have it done for every usage. > > I agree that a linker script is a better idea, I just wanted to know why > my fix wasn't working. Thanks for that. > > >>> Am I allowed to check in this patch to fix the build failure, or do I > >>> have to wait for an approval of an ARM maintainer? > >> > >> I think you need an ARM maintainer, but I first want to know why your > >> build isn't linking with libgcc. > > > > Ok, Richard is seems to be in vacation until early October. This isn't really my area; so I'm happy to trust Andrew's judgement in this case. R.