From: Janis Johnson <janis187@us.ibm.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [testsuite] Fix up attribute_plugin-test-1.C (PR testsuite/41707)
Date: Wed, 14 Oct 2009 16:53:00 -0000 [thread overview]
Message-ID: <1255538131.6099.0.camel@janis-laptop> (raw)
In-Reply-To: <20091014152130.GC14664@tyan-ft48-01.lab.bos.redhat.com>
On Wed, 2009-10-14 at 17:21 +0200, Jakub Jelinek wrote:
> Hi!
>
> Must have missed this regression when testing the BUILTINS_LOCATION patch.
> THe problem is that it calls warning (0, "...") from a callback without any
> specific location, so now is reported at <built-in>:0:0 (which is IMHO
> correct).
>
> Ok for trunk?
OK.
Janis
> 2009-10-14 Jakub Jelinek <jakub@redhat.com>
>
> PR testsuite/41707
> * g++.dg/plugin/attribute_plugin-test-1.C: Expect the first
> warning on line 0 instead of 1.
>
> --- gcc/testsuite/g++.dg/plugin/attribute_plugin-test-1.C.jj 2009-05-14 09:33:17.000000000 +0200
> +++ gcc/testsuite/g++.dg/plugin/attribute_plugin-test-1.C 2009-10-14 17:12:12.000000000 +0200
> @@ -1,4 +1,4 @@
> -// { dg-warning "Callback to register attributes" }
> +// { dg-warning "Callback to register attributes" "" { target *-*-* } 0 }
>
> void normal_func (char c, char c2);
> void normal_func (char __attribute__((user("param"))) c, char);
>
> Jakub
prev parent reply other threads:[~2009-10-14 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 15:28 Jakub Jelinek
2009-10-14 16:53 ` Janis Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255538131.6099.0.camel@janis-laptop \
--to=janis187@us.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).