public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [testsuite] Fix up attribute_plugin-test-1.C (PR testsuite/41707)
@ 2009-10-14 15:28 Jakub Jelinek
  2009-10-14 16:53 ` Janis Johnson
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2009-10-14 15:28 UTC (permalink / raw)
  To: Janis Johnson; +Cc: gcc-patches

Hi!

Must have missed this regression when testing the BUILTINS_LOCATION patch.
THe problem is that it calls warning (0, "...") from a callback without any
specific location, so now is reported at <built-in>:0:0 (which is IMHO
correct).

Ok for trunk?

2009-10-14  Jakub Jelinek  <jakub@redhat.com>

	PR testsuite/41707
	* g++.dg/plugin/attribute_plugin-test-1.C: Expect the first
	warning on line 0 instead of 1.

--- gcc/testsuite/g++.dg/plugin/attribute_plugin-test-1.C.jj	2009-05-14 09:33:17.000000000 +0200
+++ gcc/testsuite/g++.dg/plugin/attribute_plugin-test-1.C	2009-10-14 17:12:12.000000000 +0200
@@ -1,4 +1,4 @@
-// { dg-warning "Callback to register attributes" }
+// { dg-warning "Callback to register attributes" "" { target *-*-* } 0 }
 
 void normal_func (char c, char c2);
 void normal_func (char __attribute__((user("param"))) c, char);

	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [testsuite] Fix up attribute_plugin-test-1.C (PR  testsuite/41707)
  2009-10-14 15:28 [testsuite] Fix up attribute_plugin-test-1.C (PR testsuite/41707) Jakub Jelinek
@ 2009-10-14 16:53 ` Janis Johnson
  0 siblings, 0 replies; 2+ messages in thread
From: Janis Johnson @ 2009-10-14 16:53 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: gcc-patches

On Wed, 2009-10-14 at 17:21 +0200, Jakub Jelinek wrote:
> Hi!
> 
> Must have missed this regression when testing the BUILTINS_LOCATION patch.
> THe problem is that it calls warning (0, "...") from a callback without any
> specific location, so now is reported at <built-in>:0:0 (which is IMHO
> correct).
> 
> Ok for trunk?

OK.

Janis

> 2009-10-14  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR testsuite/41707
> 	* g++.dg/plugin/attribute_plugin-test-1.C: Expect the first
> 	warning on line 0 instead of 1.
> 
> --- gcc/testsuite/g++.dg/plugin/attribute_plugin-test-1.C.jj	2009-05-14 09:33:17.000000000 +0200
> +++ gcc/testsuite/g++.dg/plugin/attribute_plugin-test-1.C	2009-10-14 17:12:12.000000000 +0200
> @@ -1,4 +1,4 @@
> -// { dg-warning "Callback to register attributes" }
> +// { dg-warning "Callback to register attributes" "" { target *-*-* } 0 }
> 
>  void normal_func (char c, char c2);
>  void normal_func (char __attribute__((user("param"))) c, char);
> 
> 	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-14 16:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-14 15:28 [testsuite] Fix up attribute_plugin-test-1.C (PR testsuite/41707) Jakub Jelinek
2009-10-14 16:53 ` Janis Johnson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).