From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31210 invoked by alias); 14 Oct 2009 16:36:03 -0000 Received: (qmail 31198 invoked by uid 22791); 14 Oct 2009 16:36:02 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e34.co.us.ibm.com (HELO e34.co.us.ibm.com) (32.97.110.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Oct 2009 16:35:58 +0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id n9EGVAcb009669 for ; Wed, 14 Oct 2009 10:31:10 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9EGZa5B163134 for ; Wed, 14 Oct 2009 10:35:38 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n9EGZWSm016170 for ; Wed, 14 Oct 2009 10:35:32 -0600 Received: from [9.47.18.71] (dyn9047018071.beaverton.ibm.com [9.47.18.71]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n9EGZV5Y016039; Wed, 14 Oct 2009 10:35:32 -0600 Subject: Re: [testsuite] Fix up attribute_plugin-test-1.C (PR testsuite/41707) From: Janis Johnson Reply-To: janis187@us.ibm.com To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org In-Reply-To: <20091014152130.GC14664@tyan-ft48-01.lab.bos.redhat.com> References: <20091014152130.GC14664@tyan-ft48-01.lab.bos.redhat.com> Content-Type: text/plain Date: Wed, 14 Oct 2009 16:53:00 -0000 Message-Id: <1255538131.6099.0.camel@janis-laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg00922.txt.bz2 On Wed, 2009-10-14 at 17:21 +0200, Jakub Jelinek wrote: > Hi! > > Must have missed this regression when testing the BUILTINS_LOCATION patch. > THe problem is that it calls warning (0, "...") from a callback without any > specific location, so now is reported at :0:0 (which is IMHO > correct). > > Ok for trunk? OK. Janis > 2009-10-14 Jakub Jelinek > > PR testsuite/41707 > * g++.dg/plugin/attribute_plugin-test-1.C: Expect the first > warning on line 0 instead of 1. > > --- gcc/testsuite/g++.dg/plugin/attribute_plugin-test-1.C.jj 2009-05-14 09:33:17.000000000 +0200 > +++ gcc/testsuite/g++.dg/plugin/attribute_plugin-test-1.C 2009-10-14 17:12:12.000000000 +0200 > @@ -1,4 +1,4 @@ > -// { dg-warning "Callback to register attributes" } > +// { dg-warning "Callback to register attributes" "" { target *-*-* } 0 } > > void normal_func (char c, char c2); > void normal_func (char __attribute__((user("param"))) c, char); > > Jakub