From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Richard Sandiford <rdsandiford@googlemail.com>
Cc: David Daney <ddaney@caviumnetworks.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
linux-mips@linux-mips.org, Adam Nemet <anemet@caviumnetworks.com>,
rostedt@goodmis.org, Thomas Gleixner <tglx@linutronix.de>,
Ralf Baechle <ralf@linux-mips.org>,
Nicholas Mc Guire <der.herr@hofr.at>
Subject: Re: [PATCH] MIPS: Add option to pass return address location to _mcount.
Date: Thu, 29 Oct 2009 08:14:00 -0000 [thread overview]
Message-ID: <1256798674.6448.42.camel@falcon> (raw)
In-Reply-To: <87ljiwr0t9.fsf@firetop.home>
Hi,
On Tue, 2009-10-27 at 21:20 +0000, Richard Sandiford wrote:
[...]
> OK with those changes,
Just applied the above changes, and added one more for not getting the
ra_fp_offset when -pg is not enabled:
@@ -9619,6 +9622,9 @@ mips_for_each_saved_gpr_and_fpr (HOST_WIDE_INT
sp_offset,
for (regno = GP_REG_LAST; regno >= GP_REG_FIRST; regno--)
if (BITSET_P (cfun->machine->frame.mask, regno - GP_REG_FIRST))
{
+ /* Record the ra offset for use by mips_function_profiler. */
+ if (crtl->profile && regno == RETURN_ADDR_REGNUM)
+ cfun->machine->frame.ra_fp_offset = offset + sp_offset;
mips_save_restore_reg (word_mode, regno, offset, fn);
offset -= UNITS_PER_WORD;
}
"crtl->profile &&" was added.
> thanks, if it passing testing, and if
> Ralf is happy with the linux side.
>
Just appended that patch with the above changes to the latest gcc 4.5 in
the git repository, and tested it, which works well.
this is the result of a non-leaf function:
ffffffff80243c08 <copy_process>:
ffffffff80243c08: 67bdff40 daddiu sp,sp,-192
ffffffff80243c0c: ffbe00b0 sd s8,176(sp)
ffffffff80243c10: 03a0f02d move s8,sp
ffffffff80243c14: ffbf00b8 sd ra,184(sp)
[...]
ffffffff80243c38: 3c038021 lui v1,0x8021
ffffffff80243c3c: 64631530 daddiu v1,v1,5424
ffffffff80243c40: 03e0082d move at,ra
ffffffff80243c44: 0060f809 jalr v1
ffffffff80243c48: 67ac00b8 daddiu t0,sp,184 --> Here it is
and for a leaf function:
ffffffff802054d0 <au1k_wait>:
ffffffff802054d0: 67bdfff0 daddiu sp,sp,-16
ffffffff802054d4: ffbe0008 sd s8,8(sp)
ffffffff802054d8: 03a0f02d move s8,sp
ffffffff802054dc: 3c038021 lui v1,0x8021
ffffffff802054e0: 64631530 daddiu v1,v1,5424
ffffffff802054e4: 03e0082d move at,ra
ffffffff802054e8: 0060f809 jalr v1
ffffffff802054ec: 0000602d move t0,zero --> Here it is
and with this new feature, I can safely remove the old
ftrace_get_parent_addr() and add several more instructions to make
function graph tracer work. and also, 'Cause this feature used the
t0($12) register, I must change the temp registers I have used in the
patches of ftrace for MIPS(t0 --> t1, t1 --> t2, t2-> t3...). no more
touch.
The latest revision of this patch will be sent out in the next E-mail,
and also, the -v8 revision of ftrace for MIPS will be sent out with this
new feature of Gcc asap.
Thanks & Regards,
Wu Zhangjin
next prev parent reply other threads:[~2009-10-29 6:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <028867b99ec532b84963a35e7d552becc783cafc.1256135456.git.wuzhangjin@gmail.com>
[not found] ` <2f73eae542c47ac5bbb9f7280e6c0271d193e90d.1256135456.git.wuzhangjin@gmail.com>
[not found] ` <3f0d3515f74a58f4cfd11e61b62a129fdc21e3a7.1256135456.git.wuzhangjin@gmail.com>
[not found] ` <ea8aa927fbd184b54941e4c2ae0be8ea0b4f6b8a.1256135456.git.wuzhangjin@gmail.com>
[not found] ` <1256138686.18347.3039.camel@gandalf.stny.rr.com>
[not found] ` <1256233679.23653.7.camel@falcon>
[not found] ` <4AE0A5BE.8000601@caviumnetworks.com>
[not found] ` <87y6n36plp.fsf@firetop.home>
2009-10-23 23:25 ` [PATCH] MIPS: Add option to pass return address location to _mcount. Was: [PATCH -v4 4/9] tracing: add static function tracer support for MIPS David Daney
2009-10-24 9:32 ` Richard Sandiford
2009-10-24 16:52 ` Wu Zhangjin
2009-10-26 19:12 ` [PATCH] MIPS: Add option to pass return address location to _mcount David Daney
2009-10-27 1:19 ` Wu Zhangjin
2009-10-27 21:38 ` Richard Sandiford
2009-10-28 18:26 ` David Daney
2009-10-28 19:22 ` Richard Sandiford
2009-10-29 8:14 ` Wu Zhangjin [this message]
2009-10-29 16:35 ` David Daney
2009-10-29 18:15 ` David Daney
2009-11-03 21:26 ` Richard Sandiford
[not found] ` <96110ea5dd4d3d54eb97d0bb708a5bd81c7a50b5.1256135456.git.wuzhangjin@gmail.com>
[not found] ` <af3ec1b5cd06b6f6a461c9fa7d09a51fabccb08d.1256135456.git.wuzhangjin@gmail.com>
[not found] ` <a6f2959a69b6a77dd32cc36a5c8202f97d524f1e.1256135456.git.wuzhangjin@gmail.com>
[not found] ` <53bdfdd95ec4fa00d4cc505bb5972cf21243a14d.1256135456.git.wuzhangjin@gmail.com>
[not found] ` <26008418.post@talk.nabble.com>
2009-10-25 11:20 ` [PATCH -v4 9/9] tracing: add function graph tracer support for MIPS Wu Zhangjin
2009-10-25 14:10 ` Patrik Kluba
2009-10-25 14:52 ` Wu Zhangjin
2009-10-25 16:00 ` Richard Sandiford
2009-10-29 9:04 [PATCH] MIPS: Add option to pass return address location to _mcount Wu Zhangjin
2009-10-29 16:33 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256798674.6448.42.camel@falcon \
--to=wuzhangjin@gmail.com \
--cc=anemet@caviumnetworks.com \
--cc=ddaney@caviumnetworks.com \
--cc=der.herr@hofr.at \
--cc=gcc-patches@gcc.gnu.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rdsandiford@googlemail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).