From: Janis Johnson <janis187@us.ibm.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Andreas Schwab <schwab@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: PING: PATCH: Also check -m32 for i*86-*-linux*
Date: Wed, 18 Nov 2009 17:41:00 -0000 [thread overview]
Message-ID: <1258565889.6391.2.camel@janis-laptop> (raw)
In-Reply-To: <6dc9ffc80911180811t1470cbebid6dcbaaa1d6ead86@mail.gmail.com>
On Wed, 2009-11-18 at 08:11 -0800, H.J. Lu wrote:
> On Wed, Nov 18, 2009 at 2:01 AM, Andreas Schwab <schwab@redhat.com> wrote:
> > "H.J. Lu" <hjl.tools@gmail.com> writes:
> >
> >> diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
> >> index 05c0311..768975a 100644
> >> --- a/gcc/testsuite/gcc.misc-tests/linkage.exp
> >> +++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
> >> @@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
> >> if [ string match "*64-bit*" $file_string ] {
> >> set native_cflags "-m64"
> >> }
> >> - } elseif [istarget "x86_64-*-linux*"] {
> >> + } elseif [[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
> >
> > You want to put braces, not brackets, around the expression.
> >
>
> Here is the updated patch. OK for trunk?
OK.
Janis
prev parent reply other threads:[~2009-11-18 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 18:48 H.J. Lu
2009-11-18 10:29 ` Andreas Schwab
2009-11-18 16:16 ` H.J. Lu
2009-11-18 17:41 ` Janis Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258565889.6391.2.camel@janis-laptop \
--to=janis187@us.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=schwab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).