* PATCH, libiberty: sort AC_CHECK_FUNCs
@ 2009-11-25 5:22 Ben Elliston
2009-11-25 8:33 ` DJ Delorie
0 siblings, 1 reply; 3+ messages in thread
From: Ben Elliston @ 2009-11-25 5:22 UTC (permalink / raw)
To: gcc-patches, binutils
Cc: dj, Manuel López-Ibáñez, gcc-patches, binutils
In this message:
http://gcc.gnu.org/ml/gcc-patches/2009-08/msg00589.html
DJ notes that the list of functions in the AC_CHECK_FUNC invocation used
to be in alphabetical order. This patch fixes this--double checked with
sort(1). Found a couple of duplicates like gettimeofday and memcpy, so
this patch improves build times. :-)
OK for the trunk?
Ben
2009-11-25 Ben Elliston <bje@au.ibm.com>
* configure.ac (AC_CHECK_FUNCS): Sort into alphabetical order.
* configure: Regenerate.
Index: configure.ac
===================================================================
--- configure.ac (revision 154522)
+++ configure.ac (working copy)
@@ -362,15 +362,15 @@ checkfuncs="$checkfuncs getsysinfo table
# These are neither executed nor required, but they help keep
# autoheader happy without adding a bunch of text to acconfig.h.
if test "x" = "y"; then
- AC_CHECK_FUNCS(asprintf atexit basename bcmp bcopy bsearch bzero calloc clock \
- getcwd getpagesize gettimeofday index insque mkstemps memchr memcmp memcpy \
- memmem memmove mempcpy memset putenv random rename rindex sigsetmask \
- strcasecmp setenv stpcpy stpncpy strchr strdup strncasecmp strndup strrchr strstr \
- strtod strtol strtoul strverscmp tmpnam vasprintf vfprintf vprintf \
- vsprintf waitpid getrusage on_exit psignal strerror strsignal \
- sysconf times sbrk gettimeofday ffs snprintf vsnprintf \
- pstat_getstatic pstat_getdynamic sysmp getsysinfo table sysctl wait3 wait4 \
- realpath canonicalize_file_name __fsetlocking)
+ AC_CHECK_FUNCS(asprintf atexit basename bcmp bcopy bsearch bzero \
+ calloc canonicalize_file_name clock ffs __fsetlocking getcwd \
+ getpagesize getrusage getsysinfo gettimeofday index insque memchr \
+ memcmp memcpy memmem memmove memset mkstemps on_exit psignal \
+ pstat_getdynamic pstat_getstatic putenv random realpath rename \
+ rindex sbrk setenv sigsetmask snprintf stpcpy stpncpy strcasecmp \
+ strchr strdup strerror strncasecmp strndup strrchr strsignal strstr \
+ strtod strtol strtoul strverscmp sysconf sysctl sysmp table times \
+ tmpnam vasprintf vfprintf vprintf vsprintf wait3 wait4 waitpid)
AC_CHECK_DECLS([basename, ffs, asprintf, vasprintf, snprintf, vsnprintf])
AC_DEFINE(HAVE_SYS_ERRLIST, 1, [Define if you have the sys_errlist variable.])
AC_DEFINE(HAVE_SYS_NERR, 1, [Define if you have the sys_nerr variable.])
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH, libiberty: sort AC_CHECK_FUNCs
2009-11-25 5:22 PATCH, libiberty: sort AC_CHECK_FUNCs Ben Elliston
@ 2009-11-25 8:33 ` DJ Delorie
2009-11-25 12:22 ` Ben Elliston
0 siblings, 1 reply; 3+ messages in thread
From: DJ Delorie @ 2009-11-25 8:33 UTC (permalink / raw)
To: Ben Elliston; +Cc: gcc-patches, binutils, lopezibanez, gcc-patches, binutils
Ok. Bonus points if you put line breaks between letters instead of
just when the line is full, like CFILES in Makefile.in :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH, libiberty: sort AC_CHECK_FUNCs
2009-11-25 8:33 ` DJ Delorie
@ 2009-11-25 12:22 ` Ben Elliston
0 siblings, 0 replies; 3+ messages in thread
From: Ben Elliston @ 2009-11-25 12:22 UTC (permalink / raw)
To: DJ Delorie; +Cc: gcc-patches, binutils, lopezibanez
On Wed, 2009-11-25 at 00:22 -0500, DJ Delorie wrote:
> Ok. Bonus points if you put line breaks between letters instead of
> just when the line is full, like CFILES in Makefile.in :-)
Here is what I plan to commit tomorrow (ChangeLog unchanged)
Thanks,
Ben
Index: configure.ac
===================================================================
--- configure.ac (revision 154522)
+++ configure.ac (working copy)
@@ -362,15 +362,22 @@ checkfuncs="$checkfuncs getsysinfo table
# These are neither executed nor required, but they help keep
# autoheader happy without adding a bunch of text to acconfig.h.
if test "x" = "y"; then
- AC_CHECK_FUNCS(asprintf atexit basename bcmp bcopy bsearch bzero calloc clock \
- getcwd getpagesize gettimeofday index insque mkstemps memchr memcmp memcpy \
- memmem memmove mempcpy memset putenv random rename rindex sigsetmask \
- strcasecmp setenv stpcpy stpncpy strchr strdup strncasecmp strndup strrchr strstr \
- strtod strtol strtoul strverscmp tmpnam vasprintf vfprintf vprintf \
- vsprintf waitpid getrusage on_exit psignal strerror strsignal \
- sysconf times sbrk gettimeofday ffs snprintf vsnprintf \
- pstat_getstatic pstat_getdynamic sysmp getsysinfo table sysctl wait3 wait4 \
- realpath canonicalize_file_name __fsetlocking)
+ AC_CHECK_FUNCS(asprintf atexit \
+ basename bcmp bcopy bsearch bzero \
+ calloc canonicalize_file_name clock \
+ ffs __fsetlocking \
+ getcwd getpagesize getrusage getsysinfo gettimeofday \
+ index insque \
+ memchr memcmp memcpy memmem memmove memset mkstemps \
+ on_exit \
+ psignal pstat_getdynamic pstat_getstatic putenv \
+ random realpath rename rindex \
+ sbrk setenv sigsetmask snprintf stpcpy stpncpy strcasecmp strchr strdup \
+ strerror strncasecmp strndup strrchr strsignal strstr strtod strtol \
+ strtoul strverscmp sysconf sysctl sysmp \
+ table times tmpnam \
+ vasprintf vfprintf vprintf vsprintf \
+ wait3 wait4 waitpid)
AC_CHECK_DECLS([basename, ffs, asprintf, vasprintf, snprintf, vsnprintf])
AC_DEFINE(HAVE_SYS_ERRLIST, 1, [Define if you have the sys_errlist variable.])
AC_DEFINE(HAVE_SYS_NERR, 1, [Define if you have the sys_nerr variable.])
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-25 11:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-25 5:22 PATCH, libiberty: sort AC_CHECK_FUNCs Ben Elliston
2009-11-25 8:33 ` DJ Delorie
2009-11-25 12:22 ` Ben Elliston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).