From: Jeffrey A Law <law@cygnus.com>
To: Ulf Carlsson <ulfc@calypso.engr.sgi.com>
Cc: gcc-patches@gcc.gnu.org, Andreas Jaeger <aj@suse.de>
Subject: Re: gcse fix
Date: Wed, 12 Jul 2000 13:19:00 -0000 [thread overview]
Message-ID: <1263.963433204@upchuck> (raw)
In-Reply-To: <14688.19044.94355.794985@calypso.engr.sgi.com>
In message < 14688.19044.94355.794985@calypso.engr.sgi.com >you write:
> Note that both include a 7 in the instruction description - this is
> the line number of the inline asm. Since they're on the same line, and
> contain the same code and arguments, *** they are the same
> instruction. *** The compiler is not smart enough to know that the
> instruction operates on operands of two different modes and thus
> should be considered different - all it knows is the text inside
> __asm__() and the line number.
A valid copy can never have different modes for the source and destination
operands, so I would think the changes to can_copy_p and its related
functions are unwanted/unnecessary.
> *************** hash_scan_set (pat, insn, set_p)
> *** 1875,1881 ****
> if (! set_p
> && regno >= FIRST_PSEUDO_REGISTER
> /* Don't GCSE something if we can't do a reg/reg copy. */
> ! && can_copy_p [GET_MODE (dest)]
> /* Is SET_SRC something we want to gcse? */
> && want_to_gcse_p (src))
> {
> --- 1875,1881 ----
> if (! set_p
> && regno >= FIRST_PSEUDO_REGISTER
> /* Don't GCSE something if we can't do a reg/reg copy. */
> ! && can_copy_p [GET_MODE (dest)][GET_MODE (src)]
> /* Is SET_SRC something we want to gcse? */
> && want_to_gcse_p (src))
> {
Instead I think you just want to say
&& can_copy_p [GET_MODE (dest)]
&& GET_MODE (dest) == GET_MODE (src))
Similarly in hash_scan_set.
jeff
next prev parent reply other threads:[~2000-07-12 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-07-03 1:11 Ulf Carlsson
2000-07-12 13:19 ` Jeffrey A Law [this message]
2001-01-14 8:39 ` Andreas Jaeger
2001-01-16 10:03 ` Maciej W. Rozycki
-- strict thread matches above, loose matches on Subject: below --
2001-11-13 15:03 Jan Hubicka
2001-11-13 15:03 ` Richard Henderson
1998-10-19 23:17 Jeffrey A Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263.963433204@upchuck \
--to=law@cygnus.com \
--cc=aj@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=ulfc@calypso.engr.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).